Conversation
all tests pass except 01.04 but at least it runs
all tests passed except 7 and 12
andreachild
reviewed
Nov 28, 2024
andreachild
reviewed
Nov 28, 2024
andreachild
reviewed
Nov 28, 2024
andreachild
reviewed
Nov 28, 2024
andreachild
reviewed
Dec 6, 2024
andreachild
reviewed
Dec 10, 2024
andreachild
reviewed
Dec 10, 2024
works with appsync and tests
doesn't work so far
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Unit Test Case01.04
test Case0.104 gave
Uncaught ReferenceError: require is not definedThis is because
requireis a Node.js function but the package type is defined asmoduleinpackage.json, so we have to use ES modules likeimportandexport. But then Jest wouldn't be able to parse the file soJSResolverOCHTTPSTemplate,output.resolver.graphql.cjs,testLibwere changed to.mjsfiles to mark those files as ES modules.Changes:
JSResolverOCHTTPSTemplate,output.resolver.graphql.cjs,testLibto.mjsexport default { resolveGraphDBQueryFromAppSyncEvent, resolveGraphDBQueryFromApolloQueryEvent }so it works with the pkg import"type": "module",in the package.json files forLambda4AppSyncHTTPandLambda4AppSyncSDKin the templates folder