Skip to content

C#: Add IDatabase for compat layer#429

Closed
Yury-Fridlyand wants to merge 19 commits intocsharp/compat-layerfrom
csharp/yuryf-idatabase
Closed

C#: Add IDatabase for compat layer#429
Yury-Fridlyand wants to merge 19 commits intocsharp/compat-layerfrom
csharp/yuryf-idatabase

Conversation

@Yury-Fridlyand
Copy link

No description provided.

Maayanshani25 and others added 5 commits June 25, 2025 11:39
Signed-off-by: Maayan Shani <maayan.shani@mail.huji.ac.il>
* Fix test.

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* fix docs

---------

Signed-off-by: Edward Liang <edward.liang@improving.com>
Updated attribution files

Signed-off-by: ort-bot <valkey-glide@lists.valkey.io>
Co-authored-by: ort-bot <valkey-glide@lists.valkey.io>
Co-authored-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@yipin-chen
Copy link

Let's try to avoid SER. My suggestion is to a more generic term. For example:

csharp/sources/Valkey.Glide/SER_Compat/ConnectionMultiplexer.cs -> csharp/sources/Valkey.Glide/Abstract/ConnectionMultiplexer.cs

What do you think?

tjzhang-BQ and others added 7 commits June 26, 2025 15:58
…4267)

* Node: Validate clientAZ when using AZ affinity strategies

Signed-off-by: TJ Zhang <tj.zhang@improving.com>
Updated attribution files

Signed-off-by: ort-bot <valkey-glide@lists.valkey.io>
Co-authored-by: ort-bot <valkey-glide@lists.valkey.io>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Refactor logging statements to use the new formatting syntax for improved readability

- Updated various logging statements across multiple files to utilize the new Rust formatting syntax, replacing the older `format!("...{}", variable)` style with the more concise `format!("...{variable}")` style.
- This change enhances code clarity and reduces verbosity in log messages, making it easier to read and maintain.

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Refactor logging statements for improved readability

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
* Potential fix for code scanning alert no. 52: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 40: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 43: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 38: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 23: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 13: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 49: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 48: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 42: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 36: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 34: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 15: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

* Potential fix for code scanning alert no. 35: Workflow does not contain permissions

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>

---------

Signed-off-by: Avi Fenesh <55848801+avifenesh@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
Copilot AI and others added 7 commits July 2, 2025 11:23
valkey-io#4262)

* Initial plan

* Add Ecosystem section to README with Valkey GLIDE integrations

Co-authored-by: avifenesh <55848801+avifenesh@users.noreply.github.com>

* Clarify AWS Lambda PowerTools integration scope for idempotency feature

Co-authored-by: avifenesh <55848801+avifenesh@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: avifenesh <55848801+avifenesh@users.noreply.github.com>
valkey-io#4281)

* Update CodeQL configuration: broaden paths ignored and add workflow_dispatch trigger

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* try

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL configuration: change C-C++ build mode to manual and add specific build commands for C++ and Go

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL configuration: change Go build mode to autobuild and set Java-Kotlin to manual with build commands

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Refactor build commands for CodeQL analysis to improve readability

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL configuration: change C# build mode to manual and add build steps for C#

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Add cargo-zigbuild installation for cross-compilation in CodeQL workflow

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL workflow: modify Java build steps to skip Rust compilation

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* seperate to diff runs language based

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Refactor CodeQL workflow: simplify conditional execution for language analysis

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Fix formatting of dotnet-version in CodeQL workflow for consistency

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL workflow: specify project paths for C# build steps

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>
* Refactor CodeQL workflow: remove detect-changes job and optimize language builds

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL workflow: rename language from 'github-actions' to 'actions' and ensure Go bin directory is in PATH for protoc-gen-go installation

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL workflow: change Rust build mode to manual, create minimal lib.h for Go analysis, and enhance Go build process for CodeQL

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL workflow: change Rust build mode to none and remove Rust build steps

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

* Update CodeQL configuration: remove paths to ignore workflows

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>

---------

Signed-off-by: Avi Fenesh <aviarchi1994@gmail.com>
…ementation (valkey-io#4254)

* chore: migrate basic APITypes and enums from SER to unblock command implementations

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* chore: temporarily disable lint checks

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* fix: resolve linting issue in yml

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* Update .github/workflows/csharp.yml

Co-authored-by: Edward Liang <76571219+edlng@users.noreply.github.com>
Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com>

* fix: resolve linting issue in yml

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* refactor: rename Redis types to Valkey types and update command enums

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* refactor: migrate API types and enums from ser_ to abstract_ namespace

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* refactor: suppress Lint errors for temp files

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* chore: disable additional IDE diagnostics in .editorconfig files

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

* chore: force rebuild

Signed-off-by: jbrinkman <joe.brinkman@improving.com>

---------

Signed-off-by: jbrinkman <joe.brinkman@improving.com>
Signed-off-by: Joseph Brinkman <joe.brinkman@improving.com>
Co-authored-by: Edward Liang <76571219+edlng@users.noreply.github.com>
* Add type check for batch

Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
Co-authored-by: Edward Liang <76571219+edlng@users.noreply.github.com>
Signed-off-by: Yury-Fridlyand <yury.fridlyand@improving.com>
@Yury-Fridlyand
Copy link
Author

valkey-io#4292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants