Trix support #541
Merged
Trix support #541
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a strategy pattern to WysiwygType - add new bundle config `bit_bag_sylius_cms.wysiwyg_editor` (options: trix/ckeditor, default: ckeditor) - add trix js - add trix twig widget (bitbag_sylius_cms_plugin_trix_strategy_widget)
change installation and configuration steps in docs
christopherhero
force-pushed
the
add_trix
branch
from
f855358 to
7bedb5b
Compare
christopherhero
force-pushed
the
add_trix
branch
from
7bedb5b to
c01449c
Compare
Michal-Szczepaniak
requested changes
Feb 13, 2025
Contributor
Michal-Szczepaniak
left a comment
Michal-Szczepaniak
left a comment
There was a problem hiding this comment.
Tests need to be added
christopherhero
force-pushed
the
add_trix
branch
from
1540694 to
6299858
Compare
Michal-Szczepaniak
approved these changes
Feb 21, 2025
JanPalen
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for Trix as a WYSIWYG editor.
Drop sylius 1.12 and php 8.0
bit_bag_sylius_cms.wysiwyg_editor(options: trix/ckeditor, default: ckeditor)bitbag_sylius_cms_plugin_trix_strategy_widget)