backend/bitbox02: add integration test for payment requests #3524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benma
requested review from
Beerosagos and
bznein
and removed request for
Beerosagos
bznein
reviewed
Sep 3, 2025
Comment on lines
804
to
816
| ` | ||
| BODY: Memo from | ||
|
|
||
| Test Merchant | ||
| CONFIRM SCREEN END | ||
| CONFIRM SCREEN START | ||
| TITLE: Memo 1/2 | ||
| BODY: TextMemo line1 | ||
| CONFIRM SCREEN END | ||
| CONFIRM SCREEN START | ||
| TITLE: Memo 2/2 | ||
| BODY: TextMemo line2 | ||
| CONFIRM SCREEN END`) && |
There was a problem hiding this comment.
I know this is all gofmt doing but maybe we can extract it (and the one above) in a var so it becomes a bit easier to read the code?
bznein
approved these changes
Sep 3, 2025
So refactorings related to BitBox02 keystore transactions are sure not to break payment requests.
benma
force-pushed
the
test-paymentrequest
branch
from
17ab69c to
6a70b4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So refactorings related to BitBox02 keystore transactions are sure not to break payment requests.
This requires a simulator that is not yet released. Build it from latest bitbox02-firmware master and rename it to
simulator-v9.24.0(version in filename is required so the tests can infer the version)Then run using