frontend: remove currency selector and fix suggested account name for BTC-only. #3527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thisconnect
reviewed
Sep 2, 2025
thisconnect
reviewed
Sep 3, 2025
| @@ -69,6 +69,7 @@ export const AddAccount = ({ accounts }: TAddAccountGuide) => { | |||
| setSupportedCoins(coins); | |||
| if (onlyOneCoinIsSupported) { | |||
| setAccountCode(coins[0].suggestedAccountName); | |||
There was a problem hiding this comment.
It looks to me that you found a bug and this line was intended to set setAccountName and not account code.
There was a problem hiding this comment.
@thisconnect I agree, I removed this line and replaced it with just setAccountName. Ready for review again :)
… BTC-only. When there is only one coin supported, we want the back button on the choose name step to close the dialog. And we want the account name to be suggested.
thisconnect
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When there is only one coin supported, we want the back button on the choose name step to close the dialog. And we want the account name to be suggested.
Before asking for reviews, here is a check list of the most common things you might need to consider: