backend: update chart data for My Portfolio view#3703
Open
strmci wants to merge 1 commit intoBitBoxSwiss:masterfrom
Open
backend: update chart data for My Portfolio view#3703strmci wants to merge 1 commit intoBitBoxSwiss:masterfrom
strmci wants to merge 1 commit intoBitBoxSwiss:masterfrom
Conversation
When there were only two transactions within a short period of time, the My Portfolio chart did not display. This update ensures that the chart is shown in these situations.
benma
reviewed
Dec 8, 2025
Comment on lines
+281
to
+287
| allZero := true | ||
| for _, e := range result { | ||
| if e.Value.BigInt() != nil && e.Value.BigInt().Sign() != 0 { | ||
| allZero = false | ||
| break | ||
| } | ||
| } |
Collaborator
|
I'm not sure I like this solution, it seems to add another workaround to the chart code, which is already quite complicated. Maybe we should take some time to discuss a heavier refactoring of how the chart works to simplify it a bit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there were only two transactions within a short period of time, the My Portfolio chart did not display. This update ensures that the chart is shown in these situations.