frontend: align send-to-self tx display with other txs#3841
Open
strmci wants to merge 1 commit intoBitBoxSwiss:masterfrom
Open
frontend: align send-to-self tx display with other txs#3841strmci wants to merge 1 commit intoBitBoxSwiss:masterfrom
strmci wants to merge 1 commit intoBitBoxSwiss:masterfrom
Conversation
strmci
force-pushed
the
update_send_to_self_tx
branch
5 times, most recently
from
16dbfbf to
3f7c7ff
Compare
thisconnect
requested changes
Feb 9, 2026
strmci
force-pushed
the
update_send_to_self_tx
branch
from
3f7c7ff to
fee6e29
Compare
Collaborator
Author
|
@thisconnect thanks I addressed your comments, PTAL |
thisconnect
requested changes
Feb 11, 2026
Collaborator
thisconnect
left a comment
thisconnect
left a comment
There was a problem hiding this comment.
On small screen the text "to self .." is sometimes cut off and not shortened with ...
| "send_pending": "Sent to", | ||
| "send_to_self_complete": "Sent <amount /> to self", | ||
| "send_to_self_failed": "Failed sending <amount /> to self", | ||
| "send_to_self_pending": "Sent <amount /> to self" |
Collaborator
There was a problem hiding this comment.
Now it's much easier to read (without the <0></0>)
Is the send_to_self_pending meant to be the same string as send_to_self_complete?
If it should be the same I don't think it should add a key for every state.
Collaborator
Author
There was a problem hiding this comment.
Updated to use only one string for complete and pending.
strmci
force-pushed
the
update_send_to_self_tx
branch
from
fee6e29 to
c731db3
Compare
Keep the first row in BTC/sats and switch the second row to fiat for consistency. Since the sent amount is no longer shown on the right for send-to-self transactions, the left-side label now includes amount to keep it visible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the first row in BTC/sats and switch the second row to fiat for consistency. Since the sent amount is no longer shown on the right for send-to-self transactions, the left-side label now includes the amount to keep it visible.