Skip to content

frontend: improve amount field of input-with-account-selector #3863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thisconnect wants to merge 1 commit into
base: staging-swap
Choose a base branch
from
+21 −7
Open

frontend: improve amount field of input-with-account-selector #3863

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions frontends/web/src/routes/market/swap/components/input-with-account-selector.module.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,22 +16,40 @@
max-width: 50%;
}

.accountSelectorCol > div {
.accountSelectorCol > div { /* hack, would be good if GroupedAccountSelector had a prop to accept a className for the dropdown */
Copy link
Collaborator Author

@thisconnect thisconnect Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I try to make a PR to master so we can use normal class without targeting the direct child div.

Copy link
Collaborator Author

@thisconnect thisconnect Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found and fixed some small bugs and regressions opened PR here #3865

I'll open a PR later for fixing the hacky > div

/* removes space after groupedaccountselector inside inputwithaccountselector on desktop */
margin-bottom: 0;
}

.inputCol {
align-items: flex-end;
border: 1px solid transparent;
border-top-right-radius: var(--radius-xl);
border-bottom-right-radius: var(--radius-xl);
display: flex;
flex-basis: 50%;
flex-direction: column;
flex-grow: 0;
flex-shrink: 0;
justify-content: center;
margin-bottom: 0;
max-width: 50%;
}

.inputCol:focus-within {
border: 1px solid var(--color-blue);
}

.inputCol input,
.inputCol input:invalid,
.inputComponent > div:has(input:invalid) { /* '> div' is a bit hack, would be nice to add class directly */
Copy link
Collaborator Author

@thisconnect thisconnect Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll check if we can pass className on the input-number component, will open PR on master

border-color: transparent;
}

.inputCol:has(input:invalid:not(:focus)) {
border-color: var(--color-error);
}

.inputWithUnit {
align-items: baseline;
display: flex;
Expand Down Expand Up @@ -61,10 +79,6 @@
border-radius: 0;
}

.inputComponent > div:has(input:invalid) {
border-color: var(--color-blue);
}

.fiat {
color: var(--color-gray);
display: flex;
Expand Down
4 changes: 2 additions & 2 deletions frontends/web/src/routes/market/swap/components/input-with-account-selector.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export const InputWithAccountSelector = ({
/>
)}
</div>
<div className={style.inputCol}>
<label className={style.inputCol}>
<div className={style.inputWithUnit}>
<NumberInput
transparent
Expand All @@ -94,7 +94,7 @@ export const InputWithAccountSelector = ({
</>
) : null}
</div>
</div>
</label>
</div>
);
};