Merge pull request #5501 from BitGo/coin-3052-fix-apt-withdrawal-bugs

fix(sdk-coin-apt): strip hex prefix from public key

Author: hrishikeshjain

modules/sdk-coin-apt/src/lib/transaction/transaction.ts

@@ -174,7 +174,10 @@ export abstract class Transaction extends BaseTransaction {
 
       const feePayerAuthenticator = authenticator.fee_payer.authenticator as AccountAuthenticatorEd25519;
       const feePayerSignature = Buffer.from(feePayerAuthenticator.signature.toUint8Array());
-      this.addFeePayerSignature({ pub: feePayerAuthenticator.public_key.toString() }, feePayerSignature);
+      this.addFeePayerSignature(
+        { pub: utils.stripHexPrefix(feePayerAuthenticator.public_key.toString()) },
+        feePayerSignature
+      );
     } catch (e) {
       console.error('invalid signed transaction', e);
       throw new Error('invalid signed transaction');

modules/sdk-coin-apt/src/lib/utils.ts

@@ -43,7 +43,6 @@ export class Utils implements BaseUtils {
 
   /** @inheritdoc */
   isValidPublicKey(key: string): boolean {
-    key = this.stripHexPrefix(key);
     return isValidEd25519PublicKey(key);
   }
 

modules/sdk-coin-apt/test/unit/apt.ts

@@ -66,7 +66,7 @@ describe('APT:', function () {
 
   it('is valid pub', function () {
     // with 0x prefix
-    basecoin.isValidPub('0x9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07').should.equal(true);
+    basecoin.isValidPub('0x9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07').should.equal(false);
     // without 0x prefix
     basecoin.isValidPub('9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07').should.equal(true);
   });

modules/sdk-coin-apt/test/unit/utils.ts

@@ -44,7 +44,7 @@ describe('Aptos util library', function () {
 
   it('is valid public key', function () {
     // with 0x prefix
-    should.equal(true, utils.isValidPublicKey('0x9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07'));
+    should.equal(false, utils.isValidPublicKey('0x9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07'));
     // without 0x prefix
     should.equal(true, utils.isValidPublicKey('9b4e96086d111500259f9b38680b0509a405c1904da18976455a20c691d3bb07'));
   });