Merge pull request #5603 from BitGo/revert-5599-coin-3185-fee-estimate-multiplying-factor

Revert "feat(sdk-coin-apt): recommend min gas tank balance for next 1000 txns."

Author: bhavidhingra

modules/sdk-coin-apt/src/apt.ts

@@ -183,16 +183,6 @@ export class Apt extends BaseCoin {
     throw new Error('Method not implemented.');
   }
 
-  /** @inheritDoc */
-  getGasTankLowBalanceAlertThresholdFactor(): number {
-    return 200;
-  }
-
-  /** @inheritDoc */
-  getGasTankMinBalanceRecommendationFactor(): number {
-    return 1000;
-  }
-
   private getBuilder(): TransactionBuilderFactory {
     return new TransactionBuilderFactory(coins.get(this.getChain()));
   }

modules/sdk-coin-apt/test/unit/apt.ts

@@ -57,15 +57,11 @@ describe('APT:', function () {
     apt.getFamily().should.equal('apt');
     apt.getFullName().should.equal('Aptos');
     apt.getBaseFactor().should.equal(1e8);
-    apt.getGasTankLowBalanceAlertThresholdFactor().should.equal(200);
-    apt.getGasTankMinBalanceRecommendationFactor().should.equal(1000);
 
     tapt.getChain().should.equal('tapt');
     tapt.getFamily().should.equal('apt');
     tapt.getFullName().should.equal('Testnet Aptos');
     tapt.getBaseFactor().should.equal(1e8);
-    tapt.getGasTankLowBalanceAlertThresholdFactor().should.equal(200);
-    tapt.getGasTankMinBalanceRecommendationFactor().should.equal(1000);
   });
 
   it('is valid pub', function () {

modules/sdk-coin-arbeth/test/unit/arbeth.ts

@@ -106,8 +106,6 @@ describe('Arbitrum', function () {
       arbeth.getFamily().should.equal('arbeth');
       arbeth.getFullName().should.equal('Arbitrum Ethereum (L2 Chain)');
       arbeth.getBaseFactor().should.equal(1e18);
-      arbeth.getGasTankLowBalanceAlertThresholdFactor().should.equal(2);
-      arbeth.getGasTankMinBalanceRecommendationFactor().should.equal(10);
     });
 
     it('should return the right info for tarbeth', function () {
@@ -118,8 +116,6 @@ describe('Arbitrum', function () {
       tarbeth.getFamily().should.equal('arbeth');
       tarbeth.getFullName().should.equal('Testnet Arbitrum Ethereum (L2 Chain)');
       tarbeth.getBaseFactor().should.equal(1e18);
-      tarbeth.getGasTankLowBalanceAlertThresholdFactor().should.equal(2);
-      tarbeth.getGasTankMinBalanceRecommendationFactor().should.equal(10);
     });
   });
 

modules/sdk-core/src/bitgo/baseCoin/baseCoin.ts

@@ -599,20 +599,4 @@ export abstract class BaseCoin implements IBaseCoin {
   setCoinSpecificFieldsInIntent(intent: PopulatedIntent, params: PrebuildTransactionWithIntentOptions): void {
     return;
   }
-
-  /**
-   * Gets the multiplying factor of fee estimate to alert for low fee address balance
-   * i.e. alert threshold balance = factor * fee estimate
-   */
-  getGasTankLowBalanceAlertThresholdFactor(): number {
-    return 2;
-  }
-
-  /**
-   * Gets the multiplying factor of fee estimate for recommending the fee address min. balance
-   * i.e. recommended min. balance = factor * fee estimate
-   */
-  getGasTankMinBalanceRecommendationFactor(): number {
-    return 10;
-  }
 }

modules/sdk-core/src/bitgo/baseCoin/iBaseCoin.ts

@@ -544,6 +544,4 @@ export interface IBaseCoin {
   getHashFunction(): Hash;
   broadcastTransaction(params: BaseBroadcastTransactionOptions): Promise<BaseBroadcastTransactionResult>;
   setCoinSpecificFieldsInIntent(intent: PopulatedIntent, params: PrebuildTransactionWithIntentOptions): void;
-  getGasTankLowBalanceAlertThresholdFactor(): number;
-  getGasTankMinBalanceRecommendationFactor(): number;
 }