refactor(sdk-core): added multisig as coinfeature

lokesh-bitgo · lokesh-bitgo · commit 46e4ba38d6e9 · 2025-05-08T16:52:39.000+05:30
Ticket: WP-4028
diff --git a/modules/abstract-utxo/src/abstractUtxoCoin.ts b/modules/abstract-utxo/src/abstractUtxoCoin.ts
@@ -695,11 +695,6 @@ export abstract class AbstractUtxoCoin extends BaseCoin {
     return utxolib.bitgo.outputScripts.isSupportedScriptType(this.network, addressType);
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-algo/src/algo.ts b/modules/sdk-coin-algo/src/algo.ts
@@ -594,11 +594,6 @@ export class Algo extends BaseCoin {
     return false;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-arbeth/src/arbeth.ts b/modules/sdk-coin-arbeth/src/arbeth.ts
@@ -61,11 +61,6 @@ export class Arbeth extends AbstractEthLikeNewCoins {
     return userGasLimit;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.tss;
diff --git a/modules/sdk-coin-avaxc/src/avaxc.ts b/modules/sdk-coin-avaxc/src/avaxc.ts
@@ -135,11 +135,6 @@ export class AvaxC extends AbstractEthLikeNewCoins {
     return false;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-avaxp/src/avaxp.ts b/modules/sdk-coin-avaxp/src/avaxp.ts
@@ -60,11 +60,6 @@ export class AvaxP extends BaseCoin {
     return Math.pow(10, this._staticsCoin.decimalPlaces);
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-celo/src/celo.ts b/modules/sdk-coin-celo/src/celo.ts
@@ -25,11 +25,6 @@ export class Celo extends AbstractEthLikeCoin {
     return valid;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-cspr/src/cspr.ts b/modules/sdk-coin-cspr/src/cspr.ts
@@ -99,11 +99,6 @@ export class Cspr extends BaseCoin {
     return Math.pow(10, this._staticsCoin.decimalPlaces);
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-eos/src/eos.ts b/modules/sdk-coin-eos/src/eos.ts
@@ -232,11 +232,6 @@ export class Eos extends BaseCoin {
     return 4;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig() {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-etc/src/etc.ts b/modules/sdk-coin-etc/src/etc.ts
@@ -58,11 +58,6 @@ export class Etc extends AbstractEthLikeCoin {
     return valid;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig() {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-hbar/src/hbar.ts b/modules/sdk-coin-hbar/src/hbar.ts
@@ -570,11 +570,6 @@ export class Hbar extends BaseCoin {
     return false;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-opeth/src/opeth.ts b/modules/sdk-coin-opeth/src/opeth.ts
@@ -61,11 +61,6 @@ export class Opeth extends AbstractEthLikeNewCoins {
     return userGasLimit;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.tss;
diff --git a/modules/sdk-coin-rbtc/src/rbtc.ts b/modules/sdk-coin-rbtc/src/rbtc.ts
@@ -22,11 +22,6 @@ export class Rbtc extends AbstractEthLikeCoin {
     return valid;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig() {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-stx/src/stx.ts b/modules/sdk-coin-stx/src/stx.ts
@@ -90,11 +90,6 @@ export class Stx extends BaseCoin {
     return new TransactionBuilderFactory(coinConfig).getTransferBuilder();
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-trx/src/trx.ts b/modules/sdk-coin-trx/src/trx.ts
@@ -162,11 +162,6 @@ export class Trx extends BaseCoin {
     return true;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-xlm/src/xlm.ts b/modules/sdk-coin-xlm/src/xlm.ts
@@ -299,11 +299,6 @@ export class Xlm extends BaseCoin {
     return false;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-xrp/src/xrp.ts b/modules/sdk-coin-xrp/src/xrp.ts
@@ -116,11 +116,6 @@ export class Xrp extends BaseCoin {
     return true;
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-xtz/src/xtz.ts b/modules/sdk-coin-xtz/src/xtz.ts
@@ -51,11 +51,6 @@ export class Xtz extends BaseCoin {
     return Math.pow(10, this._staticsCoin.decimalPlaces);
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-coin-zketh/src/zketh.ts b/modules/sdk-coin-zketh/src/zketh.ts
@@ -33,11 +33,6 @@ export class Zketh extends AbstractEthLikeNewCoins {
     return await recoveryBlockchainExplorerQuery(query, explorerUrl as string);
   }
 
-  /** {@inheritDoc } **/
-  supportsMultisig(): boolean {
-    return true;
-  }
-
   /** inherited doc */
   getDefaultMultisigType(): MultisigType {
     return multisigTypes.onchain;
diff --git a/modules/sdk-core/src/bitgo/baseCoin/baseCoin.ts b/modules/sdk-core/src/bitgo/baseCoin/baseCoin.ts
@@ -2,11 +2,11 @@
  * @prettier
  */
 import * as crypto from 'crypto';
+import { Hash } from 'crypto';
+import * as utxolib from '@bitgo/utxo-lib';
 import { bip32 } from '@bitgo/utxo-lib';
 import { BigNumber } from 'bignumber.js';
-
-import * as utxolib from '@bitgo/utxo-lib';
-import { BaseCoin as StaticsBaseCoin } from '@bitgo/statics';
+import { BaseCoin as StaticsBaseCoin, CoinFeature } from '@bitgo/statics';
 
 import { InitiateRecoveryOptions } from '../recovery';
 import { signMessage } from '../bip32util';
@@ -16,17 +16,22 @@ import { Enterprises } from '../enterprise';
 import { Keychains, KeyIndices } from '../keychain';
 import { Markets } from '../market';
 import { PendingApprovals } from '../pendingApproval';
-import { Wallets, IWallet, Wallet } from '../wallet';
+import { IWallet, Wallet, Wallets } from '../wallet';
 import { Webhooks } from '../webhook';
 import {
+  BaseBroadcastTransactionOptions,
+  BaseBroadcastTransactionResult,
+  BuildNftTransferDataOptions,
+  DeriveKeyWithSeedOptions,
   ExtraPrebuildParamsOptions,
   FeeEstimateOptions,
   IBaseCoin,
-  ParsedTransaction,
   ITransactionExplanation,
   KeychainsTriplet,
   KeyPair,
   MPCAlgorithm,
+  MultisigType,
+  ParsedTransaction,
   ParseTransactionOptions,
   PrecreateBitGoOptions,
   PresignTransactionOptions,
@@ -39,14 +44,8 @@ import {
   TransactionPrebuild,
   VerifyAddressOptions,
   VerifyTransactionOptions,
-  BuildNftTransferDataOptions,
-  BaseBroadcastTransactionOptions,
-  BaseBroadcastTransactionResult,
-  DeriveKeyWithSeedOptions,
-  MultisigType,
 } from './iBaseCoin';
 import { IInscriptionBuilder } from '../inscriptionBuilder';
-import { Hash } from 'crypto';
 import { MPCSweepRecoveryOptions, MPCTxs, PopulatedIntent, PrebuildTransactionWithIntentOptions } from '../utils';
 
 export abstract class BaseCoin implements IBaseCoin {
@@ -186,11 +185,13 @@ export abstract class BaseCoin implements IBaseCoin {
   }
 
   /**
+   * @deprecated use CoinFeature.MULTISIG from statics instead
    * Flag indicating if this coin supports MultiSig wallets.
    * @return {boolean} True if MultiSig wallets can be created for this coin
    */
   supportsMultisig(): boolean {
-    return false;
+    // Use the static coin configuration to check if MULTISIG is supported
+    return this._staticsCoin.features.includes(CoinFeature.MULTISIG);
   }
 
   /**
diff --git a/modules/statics/src/avaxp.ts b/modules/statics/src/avaxp.ts
@@ -22,6 +22,7 @@ export class AVAXPCoin extends BaseCoin {
     CoinFeature.CUSTODY_BITGO_GERMANY,
     CoinFeature.CUSTODY_BITGO_FRANKFURT,
     CoinFeature.MULTISIG_COLD,
+    CoinFeature.MULTISIG,
     CoinFeature.STAKING,
   ];
 
diff --git a/modules/statics/src/base.ts b/modules/statics/src/base.ts
@@ -363,6 +363,11 @@ export enum CoinFeature {
    * This coins is an EVM compatible coin and should use common EVM functionality
    */
   SHARED_EVM_SIGNING = 'shared-evm-signing',
+
+  /**
+   * This coin supports multisig wallets
+   */
+  MULTISIG = 'multisig',
 }
 
 /**
diff --git a/modules/statics/src/coinFeatures.ts b/modules/statics/src/coinFeatures.ts
diff --git a/modules/statics/src/utxo.ts b/modules/statics/src/utxo.ts
