Merge pull request #6086 from BitGo/SC-1729-fix

fix(sdk-coin-sui): walrus request withdraw stake should have empty outputs

Author: sbplat

modules/sdk-coin-sui/src/lib/utils.ts

@@ -367,6 +367,12 @@ export class Utils implements BaseUtils {
     });
   }
 
+  isWalrusRequestWithdrawStakeTx(tx: WalrusWithdrawStakeProgrammableTransaction): boolean {
+    return tx.transactions
+      .filter((transaction) => 'kind' in transaction && transaction.kind === 'MoveCall')
+      .some(({ target }) => target.endsWith('::staking::request_withdraw_stake'));
+  }
+
   getWalrusWithdrawStakeRequests(tx: WalrusWithdrawStakeProgrammableTransaction): RequestWalrusWithdrawStake {
     let amount: number | undefined = undefined;
     let stakedWal: SuiObjectRef;

modules/sdk-coin-sui/src/lib/walrusWithdrawStakeTransaction.ts

@@ -207,6 +207,12 @@ export class WalrusWithdrawStakeTransaction extends Transaction<WalrusWithdrawSt
         coin: this._coinConfig.name,
       },
     ];
+
+    if (utils.isWalrusRequestWithdrawStakeTx(this._suiTransaction.tx)) {
+      // request withdraw stake should have no outputs
+      return;
+    }
+
     this._outputs = [
       {
         address: this.suiTransaction.sender,

modules/sdk-coin-sui/test/unit/transactionBuilder/walrusWithdrawBuilder.ts

@@ -38,12 +38,7 @@ describe('Walrus Withdraw Builder', () => {
         value: testData.STAKING_AMOUNT.toString(),
         coin: 'tsui:wal',
       });
-      tx.outputs.length.should.equal(1);
-      tx.outputs[0].should.deepEqual({
-        address: testData.sender.address,
-        value: testData.STAKING_AMOUNT.toString(),
-        coin: 'tsui:wal',
-      });
+      tx.outputs.length.should.equal(0);
 
       const rawTx = tx.toBroadcastFormat();
       await assertRebuild(rawTx);
@@ -80,12 +75,7 @@ describe('Walrus Withdraw Builder', () => {
         value: AMOUNT_UNKNOWN_TEXT,
         coin: 'tsui:wal',
       });
-      tx.outputs.length.should.equal(1);
-      tx.outputs[0].should.deepEqual({
-        address: testData.sender.address,
-        value: AMOUNT_UNKNOWN_TEXT,
-        coin: 'tsui:wal',
-      });
+      tx.outputs.length.should.equal(0);
 
       const rawTx = tx.toBroadcastFormat();
       await assertRebuild(rawTx);