refactor(abstract-utxo): make AbstractUtxoCoinWallet an interface

Issue: BTC-1450

Author: OttoAllmendinger

modules/abstract-utxo/src/wallet.ts

@@ -1,4 +1,4 @@
-import { BitGoBase, IBaseCoin, Wallet, WalletData } from '@bitgo/sdk-core';
+import { Wallet, WalletData } from '@bitgo/sdk-core';
 
 // parseTransactions' return type makes use of WalletData's type but with customChangeKeySignatures as required.
 export interface AbstractUtxoCoinWalletData extends WalletData {
@@ -9,10 +9,6 @@ export interface AbstractUtxoCoinWalletData extends WalletData {
   };
 }
 
-export class AbstractUtxoCoinWallet extends Wallet {
-  public _wallet: AbstractUtxoCoinWalletData;
-
-  constructor(bitgo: BitGoBase, baseCoin: IBaseCoin, walletData: any) {
-    super(bitgo, baseCoin, walletData);
-  }
+export interface AbstractUtxoCoinWallet extends Wallet {
+  _wallet: AbstractUtxoCoinWalletData;
 }

modules/bitgo/test/v2/unit/coins/abstractUtxoCoin.ts

@@ -1,7 +1,7 @@
 import * as utxolib from '@bitgo/utxo-lib';
 import * as should from 'should';
 import * as sinon from 'sinon';
-import { UnexpectedAddressError, VerificationOptions } from '@bitgo/sdk-core';
+import { Wallet, UnexpectedAddressError, VerificationOptions } from '@bitgo/sdk-core';
 import { TestBitGo } from '@bitgo/sdk-test';
 import { BitGo } from '../../../../src/bitgo';
 import {
@@ -31,7 +31,7 @@ describe('Abstract UTXO Coin:', () => {
       },
     };
 
-    const wallet = sinon.createStubInstance(AbstractUtxoCoinWallet, {
+    const wallet = sinon.createStubInstance(Wallet, {
       migratedFrom: 'v1_wallet_base_address',
     });
 
@@ -60,7 +60,7 @@ describe('Abstract UTXO Coin:', () => {
       const parsedTransaction = await coin.parseTransaction({
         txParams,
         txPrebuild: { txHex: '' },
-        wallet: wallet as any,
+        wallet: wallet as unknown as AbstractUtxoCoinWallet,
         verification,
       });
 
@@ -177,8 +177,8 @@ describe('Abstract UTXO Coin:', () => {
     });
 
     it('should consider addresses derived from the custom change keys as internal spends', async () => {
-      const signedSendingWallet = sinon.createStubInstance(AbstractUtxoCoinWallet, stubData.signedSendingWallet as any);
-      const changeWallet = sinon.createStubInstance(AbstractUtxoCoinWallet, stubData.changeWallet as any);
+      const signedSendingWallet = sinon.createStubInstance(Wallet, stubData.signedSendingWallet as any);
+      const changeWallet = sinon.createStubInstance(Wallet, stubData.changeWallet as any);
 
       sinon.stub(coin, 'keychains').returns({
         get: sinon.stub().callsFake(({ id }) => {
@@ -319,14 +319,11 @@ describe('Abstract UTXO Coin:', () => {
       },
     };
 
-    const unsignedSendingWallet = sinon.createStubInstance(
-      AbstractUtxoCoinWallet,
-      stubData.unsignedSendingWallet as any
-    );
+    const unsignedSendingWallet = sinon.createStubInstance(Wallet, stubData.unsignedSendingWallet as any);
 
     it('should fail if the user private key cannot be verified to match the user public key', async () => {
       sinon.stub(coin, 'parseTransaction').resolves(stubData.parseTransactionData.badKey as any);
-      const verifyWallet = sinon.createStubInstance(AbstractUtxoCoinWallet, {});
+      const verifyWallet = sinon.createStubInstance(Wallet, {});
 
       await coin
         .verifyTransaction({