Merge pull request #6053 from BitGo/COIN-3940-fix-isValidAddress-tron

fix(sdk-coin-trx): isValidAddress allows only base58 address format

Author: gianchandania

modules/sdk-coin-trx/src/trx.ts

@@ -190,15 +190,15 @@ export class Trx extends BaseCoin {
   }
 
   /**
-   * Checks if this is a valid base58 or hex address
+   * Checks if this is a valid base58
    * @param address
    */
   isValidAddress(address: string): boolean {
     if (!address) {
       return false;
     }
 
-    return this.isValidHexAddress(address) || Utils.isBase58Address(address);
+    return Utils.isBase58Address(address);
   }
 
   /**

modules/sdk-coin-trx/test/unit/trx.ts

@@ -62,17 +62,14 @@ describe('TRON:', function () {
       'TBChwKYNaTo4a4N68Me1qEiiKsRDspXqLLZ',
       '0x96be113992bdc3be24c11f6017085b605d253649',
       '0x341qg3922b1',
-    ];
-    const goodAddresses = [
-      'TBChwKYNaTo4a4N68Me1qEiiKsRDspXqLp',
-      'TPcf5jtYUhCN1X14tN577zF4NepbDZbxT7',
       '41E0C0F581D7D02D40826C1C6CBEE71F625D6344D0',
       '412C2BA4A9FF6C53207DC5B686BFECF75EA7B80577',
       '418840E6C55B9ADA326D211D818C34A994AECED808',
       '412A2B9F7641D0750C1E822D0E49EF765C8106524B',
       '41A614F803B6FD780986A42C78EC9C7F77E6DED13C',
       '418840E6C55B9ADA326D211D818C34A994AECED808',
     ];
+    const goodAddresses = ['TBChwKYNaTo4a4N68Me1qEiiKsRDspXqLp', 'TPcf5jtYUhCN1X14tN577zF4NepbDZbxT7'];
 
     badAddresses.map((addr) => {
       assert.equal(basecoin.isValidAddress(addr), false);