Win 3948 optimized onboarding of tokens #5234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parasgarg-bitgo
previously approved these changes
Dec 10, 2024
lcovar
previously approved these changes
Dec 10, 2024
rv-bitgo
force-pushed
the
WIN-3948-optimized-onboarding-of-tokens
branch
from
ac0cf38 to
a39c131
Compare
rv-bitgo
dismissed stale reviews from lcovar and parasgarg-bitgo
via
ab7d58f
WIN-3948 feat(statics): add tokens for onboarding WIN-3948 feat(statics): added batch of tokens for onboarding WIN-3948 fix(statics): fix syntax WIN-3948 feat(statics): add tokens for onboarding WIN-3948 TICKET: WIN-3948 feat(statics): onboard new tokens - optimized WIN-3948 TICKET: WIN-3948 fix(statics): fix the ts syntax and import WIN-3948 TICKET: WIN-3948 fix: fix the decimal unit and name of tokens as per ticket WIN-3948 TICKET: WIN-3948
rv-bitgo
force-pushed
the
WIN-3948-optimized-onboarding-of-tokens
branch
from
ab7d58f to
d808dab
Compare
mohd-kashif
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A slightly better approach to managing coins.ts file.
coins.ts has already ~20,000 lines of code config which is bound to only grow with time if we keep adding new tokens/coins to it on every onboarding. This comes with the pro of easily putting all tokens in one place but comes at a cost of easily messing up the entire flow by a single mistake.
I propose any new onboarded coins be put into smaller files that can be unique to their assets (erc20, sol and so on.).
Please check this out and let me know what do you guys think of this structure and any potential issues that might come with this approach.