fix(abstract-eth): fix issue with ethlike signTx #5238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noel-bitgo
previously approved these changes
Dec 11, 2024
Contributor
noel-bitgo
left a comment
noel-bitgo
left a comment
There was a problem hiding this comment.
Any test that would validate the output?
gianchandania
force-pushed
the
COIN-2506-fix-issue-in-ovc-signing
branch
from
27f97e9 to
7584c8b
Compare
Contributor
Author
added the test |
noel-bitgo
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of signing a custodial tx with contract data, we were getting transaction data does not match original because halfSigned tx was not having data field. This PR fixes the same. Taking recipients from params similar to eth
COIN-2506
TICKET: COIN-2506