feat(sdk-coin-apt): transaction builder #5318
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
8 times, most recently
from
99e7b80 to
6857221
Compare
baltiyal
force-pushed
the
coin-2258-apt-tx-builder-1
branch
3 times, most recently
from
69cca5b to
db3ebe7
Compare
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
db3ebe7 to
a19ac5e
Compare
baltiyal
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
a19ac5e to
76f45da
Compare
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
7 times, most recently
from
3b8ac25 to
c2c10e6
Compare
bhavidhingra
commented
Jan 7, 2025
baltiyal
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
3e9cece to
bf6cf07
Compare
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
bf6cf07 to
f89fe65
Compare
bhavidhingra
commented
Jan 7, 2025
baltiyal
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
f89fe65 to
f9c219f
Compare
bhavidhingra
commented
Jan 8, 2025
bhavidhingra
commented
Jan 8, 2025
bhavidhingra
commented
Jan 8, 2025
bhavidhingra
commented
Jan 8, 2025
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
f9c219f to
34c7ec8
Compare
baltiyal
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
bc95236 to
fd2df47
Compare
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
fd2df47 to
19eeb3e
Compare
baltiyal
force-pushed
the
coin-2258-apt-tx-builder-1
branch
2 times, most recently
from
87eb5d5 to
8016b29
Compare
alebusse
reviewed
Jan 9, 2025
modules/sdk-coin-apt/package.json
Outdated
| "dependencies": { | ||
| "@aptos-labs/ts-sdk": "^1.32.0", | ||
| "@bitgo/sdk-core": "^28.18.0", | ||
| "@bitgo/sdk-lib-mpc": "^10.1.0", |
There was a problem hiding this comment.
I think i can be moved to dev dependencies
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
2 times, most recently
from
1f1f302 to
3f79f20
Compare
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
3f79f20 to
98850dd
Compare
bhavidhingra
force-pushed
the
coin-2258-apt-tx-builder-1
branch
from
98850dd to
660e37a
Compare
MohammedRyaan786
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: COIN-2258