feat(statics): ungate assets for frankfurt trust #5338
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogeshwar-bitgo
force-pushed
the
WIN-4115-ungate
branch
from
bdecb9f to
d2443be
Compare
yogeshwar-bitgo
changed the title
yogeshwar-bitgo
force-pushed
the
WIN-4115-ungate
branch
3 times, most recently
from
fdc0f52 to
9ab8cc2
Compare
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
PR is in draft and failing CI.
yogeshwar-bitgo
force-pushed
the
WIN-4115-ungate
branch
2 times, most recently
from
bec06b3 to
8883881
Compare
yogeshwar-bitgo
force-pushed
the
WIN-4115-ungate
branch
from
71c009a to
9ee9710
Compare
akshay-bitgo
approved these changes
Jan 8, 2025
Contributor
akshay-bitgo
left a comment
akshay-bitgo
left a comment
There was a problem hiding this comment.
minor comments, else LGTM
| yfii: { features: [CoinFeature.CUSTODY_BITGO_FRANKFURT] }, | ||
| yld: { features: [CoinFeature.CUSTODY_BITGO_FRANKFURT] }, | ||
| zil: { features: [CoinFeature.CUSTODY_BITGO_FRANKFURT] }, | ||
|
|
Contributor
There was a problem hiding this comment.
nit: check if empty line is needed.
| '0xae78736cd615f374d3085123a210448e74fc6393', | ||
| UnderlyingAsset['RETH-ROCKET'], | ||
| RETH_ROCKET_FEATURES | ||
| [...RETH_ROCKET_FEATURES, CoinFeature.CUSTODY_BITGO_FRANKFURT] |
Contributor
There was a problem hiding this comment.
nit: I see that in some coins we create feature and then use it.
You might want to consider using it.
const RETH-ROCKET_FEATURES = [
...RETH_ROCKET_FEATURES, CoinFeature.CUSTODY_BITGO_FRANKFURT
];
Contributor
Author
There was a problem hiding this comment.
Its good when we have to use it in multiple places. I thought since its single usage, have directly defined.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-4115