Skip to content

chore: onboard GoUSD token with eth prefix WIN-4114 #5342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rv-bitgo merged 1 commit into from
Jan 7, 2025
Merged

chore: onboard GoUSD token with eth prefix WIN-4114 #5342

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/statics/src/base.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1533,7 +1533,6 @@ export enum UnderlyingAsset {
TGBP = 'tgbp',
TUSDS = 'tusds',
TGOUSD = 'tgousd',
GOUSD = 'gousd',
Copy link
Contributor

@sachushaji sachushaji Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need to change the base to eth: gousd?, only name needs to be changed?

Copy link
Contributor Author

@rv-bitgo rv-bitgo Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing base isn't required but I just follow the convention since starting and since there are no enforcing rules, I stick to prefix eth to erc20 tokens.

THKD = 'thkd',
THUNDER = 'thunder',
TIO = 'tio',
Expand Down Expand Up @@ -1794,6 +1793,7 @@ export enum UnderlyingAsset {
'eth:audu' = 'eth:audu',
'eth:wlfi' = 'eth:wlfi',
'eth:kava' = 'eth:kava',
'eth:gousd' = 'eth:gousd',
'eth:iq' = 'eth:iq',
'eth:iris' = 'eth:iris',
'eth:hard' = 'eth:hard',
Expand Down
4 changes: 2 additions & 2 deletions modules/statics/src/coins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4538,11 +4538,11 @@ export const coins = CoinMap.fromCoins([
),
erc20(
'5552fd84-9354-4776-873e-a0e40a6b1675',
'gousd',
'eth:gousd',
'goUSD',
6,
'0xf1f6b8cc3a0d544a40f1d29909396378370e6938',
UnderlyingAsset.GOUSD
UnderlyingAsset['eth:gousd']
Copy link
Contributor

@sachushaji sachushaji Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to change the token name with eth prefixed?

Copy link
Contributor Author

@rv-bitgo rv-bitgo Jan 7, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated.

),
erc20(
'3628927c-05c7-4fba-9fc3-f3c17e261334',
Expand Down
Loading