Skip to content

fix: add --ignore-scripts argument to yarn cache key #7390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

fix: add --ignore-scripts argument to yarn cache key #7390

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
path: |
node_modules
modules/*/node_modules
key: ${{ runner.os }}-node${{matrix.node-version}}-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('**/package.json') }}
key: ${{ runner.os }}-node${{matrix.node-version}}-ignore-scripts-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('**/package.json') }}

- name: Install Packages
if: steps.lerna-cache.outputs.cache-hit != 'true' || contains( github.event.pull_request.labels.*.name, 'SKIP_CACHE')
Expand Down Expand Up @@ -106,7 +106,7 @@ jobs:
path: |
node_modules
modules/*/node_modules
key: ${{ runner.os }}-node20-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('**/package.json') }}
key: ${{ runner.os }}-node20-ignore-scripts-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('**/package.json') }}

- name: Install Packages
if: steps.lerna-cache.outputs.cache-hit != 'true' || contains( github.event.pull_request.labels.*.name, 'SKIP_CACHE')
Expand Down Expand Up @@ -152,7 +152,7 @@ jobs:
path: |
node_modules
modules/*/node_modules
key: ${{ runner.os }}-node22-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('**/package.json') }}
key: ${{ runner.os }}-node22-ignore-scripts-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('**/package.json') }}

- name: Install Packages
if: steps.lerna-cache.outputs.cache-hit != 'true'
Expand Down Expand Up @@ -300,38 +300,38 @@ jobs:
id: docker-test
run: |
echo "Testing Docker image bitgo/express:${{ github.sha }}"

CONTAINER_ID=$(docker run -d -p 3080:3080 bitgo/express:${{ github.sha }})
echo "Started container: $CONTAINER_ID"

# Wait for the service to be ready with timeout
echo "Waiting for service to be ready..."

for i in {1..30}; do
if curl -f -s --max-time 5 http://localhost:3080/api/v2/ping > /dev/null 2>&1; then
echo "✅ API health check passed"
break
fi

if [ $i -eq 30 ]; then
echo "::error::API health check failed after 30 attempts"
docker logs "$CONTAINER_ID"
docker stop "$CONTAINER_ID"
docker rm "$CONTAINER_ID"
exit 1
fi

echo "Waiting for API... (attempt $i/30)"
sleep 2
done

# Check container logs for errors
docker logs "$CONTAINER_ID"

# Stop the container
docker stop "$CONTAINER_ID"
docker rm "$CONTAINER_ID"

echo "✅ Docker image tests passed"

dockerfile-check:
Expand All @@ -354,7 +354,7 @@ jobs:
path: |
node_modules
modules/*/node_modules
key: ${{ runner.os }}-node22-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json')}}-${{ hashFiles('**/package.json') }}
key: ${{ runner.os }}-node22-ignore-scripts-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json')}}-${{ hashFiles('**/package.json') }}

- name: Install Packages
if: steps.lerna-cache.outputs.cache-hit != 'true' || contains( github.event.pull_request.labels.*.name, 'SKIP_CACHE')
Expand Down
Loading