feat(express): migrated sendmany as type route #7398
Conversation
lokesh-bitgo
requested review from
Marzooqa,
danielzhao122,
mrdanish26 and
zahin-mohammad
lokesh-bitgo
dismissed stale reviews from danielzhao122 and rahulhegde-bitgo
via
7abc5ce
lokesh-bitgo
force-pushed
the
WP-5427-express-migrate-api-v-2-coin-wallet-id-sendmany-to-typed-routes
branch
from
4f0014c to
7abc5ce
Compare
| * @param req | ||
| */ | ||
| async function handleV2SendMany(req: express.Request) { | ||
| async function handleV2SendMany(req: ExpressApiRouteRequest<'express.v2.wallet.sendmany', 'post'>) { |
There was a problem hiding this comment.
While this works, we lose the type saftey of api-ts when using things like createTSSSendParams and createSendParams. Can we have a follow up to fix these?
As long as we have those two utilities, the codec and the actual request body we are acting on won't be aligned.
| * This endpoint supports the full set of parameters available in the BitGo SDK | ||
| * for building, signing, and sending transactions to multiple recipients. | ||
| */ | ||
| export const SendManyRequestBody = { |
There was a problem hiding this comment.
How can everything be optional?
There was a problem hiding this comment.
These codecs will eventually generate our api-docs, so it will be an issue if we advertise params as required, then change to optional, then back to required.
| /** Transaction request object */ | ||
| txRequest: t.unknown, |
There was a problem hiding this comment.
This will look like a breaking change in our docs.
Please cross-reference https://developers.bitgo.com/reference/expresswalletsendmany to ensure we aren't introducing breaking changes, and if we are, we should only be introducing them to match what the code is currently doing.
Ticket: WP-5427