fix(express): pendingApprovalV1 type codec #7510
Open
+76
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taseen08
reviewed
Nov 13, 2025
Contributor
Taseen08
left a comment
Taseen08
left a comment
There was a problem hiding this comment.
one nit, lgtm otherwise
| }; | ||
|
|
||
| export const pendingApprovalRequestBody = { | ||
| /** State of the approval: 'approved' to approve, omit or 'rejected' to reject (defaults to rejection) */ |
Contributor
There was a problem hiding this comment.
nit: would it make more sense if we say: 'approved' to approve, 'rejected' to reject (defaults to rejection)
Some might think omit is a valid state to pass. I think defaults to rejection already covers that providing empty state value leads to rejection
Contributor
Author
There was a problem hiding this comment.
Will update this in the follow-up API doc tickets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WP-6717