WIN-7770-3 | flrp export C to P transaction builder #7552
Merged
+1,777
−8,316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohd-kashif
force-pushed
the
WIN-7770-3
branch
from
9916ff3 to
b044733
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mohd-kashif
force-pushed
the
WIN-7770-3
branch
from
6cc2e9b to
9504458
Compare
mohd-kashif
changed the title
Contributor
Author
|
there are some refactoring and Todos which i will be picking in the subsequent PRs for import transaction builders |
mohd-kashif
force-pushed
the
WIN-7770-3
branch
2 times, most recently
from
3171fb0 to
ed8cbc9
Compare
parasgarg-bitgo
requested changes
Nov 26, 2025
Contributor
parasgarg-bitgo
left a comment
parasgarg-bitgo
left a comment
There was a problem hiding this comment.
Please also consider breaking the PR into multiple smaller PRs. I'd suggest breaking it down in 3 PRs
- Remove irrelevant code
- Add transaction base and concrete implementations
- Add transaction builder and factory
mohd-kashif
force-pushed
the
WIN-7770-3
branch
from
639f899 to
c73a237
Compare
parasgarg-bitgo
approved these changes
Nov 27, 2025
mohd-kashif
force-pushed
the
WIN-7770-3
branch
from
c73a237 to
748e196
Compare
… with test cases\ Ticket: WIN-7770
mohd-kashif
force-pushed
the
WIN-7770-3
branch
from
748e196 to
764be80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.