Skip to content

fix: GHSA-vqpr-j7v3-hqw9 CVE-2025-66020 #7645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hitansh-madan merged 1 commit into from
Nov 27, 2025
+13 −11
Merged

fix: GHSA-vqpr-j7v3-hqw9 CVE-2025-66020 #7645

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions modules/sdk-coin-iota/src/lib/transaction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import {
} from '@bitgo/sdk-core';
import { BaseCoin as CoinConfig } from '@bitgo/statics';
import {
TransactionData as IotaTransactionData,
Transaction as IotaTransaction,
TransactionDataBuilder as IotaTransactionDataBuilder,
} from '@iota/iota-sdk/transactions';
Expand Down Expand Up @@ -38,7 +39,7 @@ export abstract class Transaction extends BaseTransaction {
private _sender: string;
private _signature?: Signature;
private _gasSponsorSignature?: Signature;
private _txDataBytes?: Uint8Array<ArrayBuffer>;
private _txDataBytes?: Uint8Array<ArrayBufferLike>;
private _isSimulateTx: boolean;

protected constructor(coinConfig: Readonly<CoinConfig>) {
Expand Down Expand Up @@ -154,11 +155,11 @@ export abstract class Transaction extends BaseTransaction {
}

async toBroadcastFormat(): Promise<string> {
const txDataBytes: Uint8Array<ArrayBuffer> = await this.build();
const txDataBytes: Uint8Array<ArrayBufferLike> = await this.build();
return toBase64(txDataBytes);
}

async build(): Promise<Uint8Array<ArrayBuffer>> {
async build(): Promise<Uint8Array<ArrayBufferLike>> {
if (this.isSimulateTx) {
return this.buildDryRunTransaction();
}
Expand Down Expand Up @@ -265,10 +266,10 @@ export abstract class Transaction extends BaseTransaction {
explanationResult: TransactionExplanation
): TransactionExplanation;

private async buildDryRunTransaction(): Promise<Uint8Array<ArrayBuffer>> {
private async buildDryRunTransaction(): Promise<Uint8Array<ArrayBufferLike>> {
this.validateTxDataImplementation();
await this.populateTxData();
const txDataBuilder = new IotaTransactionDataBuilder(this._iotaTransaction.getData());
const txDataBuilder = new IotaTransactionDataBuilder(this._iotaTransaction.getData() as IotaTransactionData);
return txDataBuilder.build({
overrides: {
gasData: {
Expand All @@ -280,7 +281,7 @@ export abstract class Transaction extends BaseTransaction {
});
}

private async buildTransaction(): Promise<Uint8Array<ArrayBuffer>> {
private async buildTransaction(): Promise<Uint8Array<ArrayBufferLike>> {
if (this._txDataBytes === undefined || this._rebuildRequired) {
this.validateTxData();
await this.populateTxData();
Expand Down
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,8 @@
"request": "npm:@cypress/[email protected]",
"**/avalanche/store2": "2.14.4",
"webpack-dev-server": "5.2.1",
"memfs": "4.46.0"
"memfs": "4.46.0",
"**/iota-sdk/**/valibot": "1.2.0"
},
"workspaces": [
"modules/*"
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20634,10 +20634,10 @@ v8-compile-cache@^2.0.3:
resolved "https://registry.npmjs.org/v8-compile-cache/-/v8-compile-cache-2.4.0.tgz"
integrity sha512-ocyWc3bAHBB/guyqJQVI5o4BZkPhznPYUG2ea80Gond/BgNWpap8TOmLSeeQG7bnh2KMISxskdADG59j7zruhw==

valibot@^0.36.0:
version "0.36.0"
resolved "https://registry.npmjs.org/valibot/-/valibot-0.36.0.tgz"
integrity sha512-CjF1XN4sUce8sBK9TixrDqFM7RwNkuXdJu174/AwmQUB62QbCQADg5lLe8ldBalFgtj1uKj+pKwDJiNo4Mn+eQ==
valibot@1.2.0, valibot@^0.36.0:
version "1.2.0"
resolved "https://registry.npmjs.org/valibot/-/valibot-1.2.0.tgz#8fc720d9e4082ba16e30a914064a39619b2f1d6f"
integrity sha512-mm1rxUsmOxzrwnX5arGS+U4T25RdvpPjPN4yR0u9pUBov9+zGVtO84tif1eY4r6zWxVxu3KzIyknJy3rxfRZZg==

[email protected], validate-npm-package-license@^3.0.1, validate-npm-package-license@^3.0.4:
version "3.0.4"
Expand Down