feat(wasm-utxo): improve address handling and network validation #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion Add support for specifying the address format when generating addresses in the fixedScriptWallet module. This allows controlling the output format (e.g., cashaddr for BCH/ECASH) when needed. Added JSDoc documentation explaining the addressFormat parameter usage and the available format options for Bitcoin Cash and eCash networks. Issue: BTC-2652 Co-authored-by: llm-git <[email protected]>
OttoAllmendinger
force-pushed
the
BTC-2652.harden-output-script-creation
branch
2 times, most recently
from
ba18483 to
05436e9
Compare
Add proper validation for supported script types based on network capabilities. This adds checks for SegWit and Taproot support in the output script generation methods, ensuring scripts are only created for networks that support them. - Add OutputScriptSupport struct to verify script compatibility - Add network parameter to outputScript function - Implement per-network script validation logic - Document supported features across different networks Issue: BTC-2652 Co-authored-by: llm-git <[email protected]>
Rename Network class to UtxolibNetwork to better represent its purpose as a compatibility layer with utxo-lib. This helps avoid confusion with other network objects while maintaining functionality. Issue: BTC-2652 Co-authored-by: llm-git <[email protected]>
OttoAllmendinger
force-pushed
the
BTC-2652.harden-output-script-creation
branch
from
05436e9 to
20951a5
Compare
Comment on lines
+4
to
+7
| /** | ||
| * Most coins only have one unambiguous address format (base58check and bech32/bech32m) | ||
| * For Bitcoin Cash and eCash, we can select between base58check and cashaddr. | ||
| */ |
Contributor
There was a problem hiding this comment.
might be a good idea for us to migrate to only cashaddr for descriptor wallets
davidkaplanbitgo
approved these changes
Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enhances the WASM UTXO module with several improvements to address
handling and network validation:
Add optional addressFormat parameter to the address function, allowing
control over output format (e.g., cashaddr for BCH/ECASH)
Add network parameter to output script validation to ensure scripts are
only created for networks that support specific features:
Rename Network class to UtxolibNetwork for better semantics and to
avoid confusion with other network objects while maintaining functionality
BTC-2652