chore: fix debug log %s formatting

Ticket: WP-00000

Author: pranavjain97

src/api/enclaved/signMultisigTransaction.ts

@@ -1,5 +1,5 @@
 import { KmsClient } from '../../kms/kmsClient';
-import { RequestTracer, TransactionPrebuild } from 'bitgo';
+import { TransactionPrebuild } from 'bitgo';
 import logger from '../../logger';
 import { EnclavedApiSpecRouteRequest } from '../../enclavedBitgoExpress/routers/enclavedApiSpec';
 

src/logger.ts

@@ -32,9 +32,17 @@ winston.addColors(colors);
 const format = winston.format.combine(
   winston.format.timestamp({ format: 'YYYY-MM-DD HH:mm:ss:ms' }),
   winston.format.colorize({ all: true }),
-  winston.format.printf(
-    (info: winston.Logform.TransformableInfo) => `${info.timestamp} ${info.level}: ${info.message}`,
-  ),
+  winston.format.printf((info: winston.Logform.TransformableInfo) => {
+    // Handle both string interpolation and object logging
+    const message = typeof info.message === 'string' ? info.message : JSON.stringify(info.message);
+
+    // If there are additional arguments, format them
+    const args = (info[Symbol.for('splat')] as any[]) || [];
+    const formattedMessage =
+      args.length > 0 ? message.replace(/%s/g, () => String(args.shift() || '')) : message;
+
+    return `${info.timestamp} ${info.level}: ${formattedMessage}`;
+  }),
 );
 
 // Define which transports the logger must use

src/masterBitgoExpress/handleSendMany.ts

@@ -1,8 +1,8 @@
 import { RequestTracer, PrebuildTransactionOptions, Memo } from '@bitgo/sdk-core';
-import { BitGoRequest } from '../types/request';
 import { createEnclavedExpressClient } from './enclavedExpressClient';
 import logger from '../logger';
 import { MasterApiSpecRouteRequest } from './routers/masterApiSpec';
+import { isMasterExpressConfig } from '../config';
 
 /**
  * Defines the structure for a single recipient in a send-many transaction.
@@ -18,6 +18,9 @@ interface Recipient {
 }
 
 export async function handleSendMany(req: MasterApiSpecRouteRequest<'v1.wallet.sendMany', 'post'>) {
+  if (!isMasterExpressConfig(req.config)) {
+    throw new Error('Configuration must be in master express mode');
+  }
   const enclavedExpressClient = createEnclavedExpressClient(req.config, req.params.coin);
   if (!enclavedExpressClient) {
     throw new Error('Please configure enclaved express configs to sign the transactions.');
@@ -35,10 +38,10 @@ export async function handleSendMany(req: MasterApiSpecRouteRequest<'v1.wallet.s
     throw new Error(`Wallet ${walletId} not found`);
   }
 
-  // @ts-ignore
-  if (wallet.type() !== 'cold' || wallet.subType() !== 'onPrem') {
-    throw new Error('Wallet is not an on-prem wallet');
-  }
+  // TODO: uncomment when on-prem type is added to SDK
+  // if (wallet.type() !== 'cold' || wallet.subType() !== 'onPrem') {
+  //   throw new Error('Wallet is not an on-prem wallet');
+  // }
 
   // Get the signing keychains
   const signingKeychains = await baseCoin.keychains().getKeysForSigning({