Wp eddsa keygen draft#38
Merged
mohammadalfaiyazbitgo merged 5 commits intoWP-eddsa-keygenfrom Jun 24, 2025
Merged
Conversation
alextse-bg
force-pushed
the
WP-eddsa-keygen-draft
branch
from
63b09a7 to
b8086e0
Compare
mohammadalfaiyazbitgo
requested changes
Jun 23, 2025
|
|
||
| // Decrypt the encrypted payload using encryptedDataKey to retrieve the previous state of computation | ||
| const decryptedDataKey = await kms.decryptDataKey(encryptedDataKey); | ||
| const previousState = JSON.parse( |
Contributor
There was a problem hiding this comment.
type this to KeyShare
| bitgoGpgKey: t.string, | ||
| userGpgKey: t.union([t.undefined, t.string]), | ||
| bitgoGpgPub: t.string, | ||
| counterPartyGpgPub: t.string, // TODO: this should be optional, but I cannot make this optional |
Contributor
There was a problem hiding this comment.
t.union([t.undefined, t.string]).
| export type MpcFinalizeRequestType = t.TypeOf<typeof MpcFinalizeRequestType>; | ||
|
|
||
| const MpcFinalizeResponse = { | ||
| combinedKey: t.any, |
Contributor
There was a problem hiding this comment.
Suggested change
| combinedKey: t.any, | |
| combinedKey: t.any, |
remove this, this is being stored on kms.
alextse-bg
force-pushed
the
WP-eddsa-keygen-draft
branch
3 times, most recently
from
e1dbe19 to
7808283
Compare
# Conflicts: # src/enclavedBitgoExpress/routers/enclavedApiSpec.ts
mohammadalfaiyazbitgo
force-pushed
the
WP-eddsa-keygen-draft
branch
from
dd486ce to
746c96c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.