feat(mbe): add bitgo integration and generate wallet api#4
Merged
mohammadalfaiyazbitgo merged 5 commits intomasterfrom Jun 2, 2025
Merged
feat(mbe): add bitgo integration and generate wallet api#4mohammadalfaiyazbitgo merged 5 commits intomasterfrom
mohammadalfaiyazbitgo merged 5 commits intomasterfrom
Conversation
pranavjain97
force-pushed
the
WP-4593-add-bitgo-generate-wallet
branch
from
37e1b2f to
737fedd
Compare
mohammadalfaiyazbitgo
force-pushed
the
WP-4593-add-bitgo-generate-wallet
branch
2 times, most recently
from
1474b44 to
9cf361d
Compare
mohammadalfaiyazbitgo
force-pushed
the
WP-4593-add-bitgo-generate-wallet
branch
from
9cf361d to
41827fb
Compare
zahin-mohammad
approved these changes
Jun 2, 2025
Contributor
zahin-mohammad
left a comment
zahin-mohammad
left a comment
There was a problem hiding this comment.
:stamp: to unblock dev, but TAL at the comments
Comment on lines
+1
to
+3
| /** | ||
| * @prettier | ||
| */ |
Contributor
There was a problem hiding this comment.
Why do you need this comment here? Why not just prettify all files?
| app.post( | ||
| '/api/:coin/wallet/generate', | ||
| parseBody, | ||
| prepareBitGo(config() as MasterExpressConfig), |
| import { handleGenerateWalletOnPrem } from './masterBitgoExpress/generateWallet'; | ||
|
|
||
| const debugLogger = debug('master-express:express'); | ||
| const BITGOEXPRESS_USER_AGENT = `BitGoExpress/${pjson.version} BitGoJS/${version}`; |
Contributor
There was a problem hiding this comment.
Suggested change
| const BITGOEXPRESS_USER_AGENT = `BitGoExpress/${pjson.version} BitGoJS/${version}`; | |
| const BITGOEXPRESS_USER_AGENT = `MasterExpress/${pjson.version} BitGoJS/${version}`; |
Comment on lines
+168
to
+172
| console.log('SSL Enabled:', cfg.enableSSL); | ||
| console.log('Enclaved Express URL:', cfg.enclavedExpressUrl); | ||
| console.log('Certificate exists:', Boolean(cfg.enclavedExpressSSLCert)); | ||
| console.log('Certificate length:', cfg.enclavedExpressSSLCert.length); | ||
| console.log('Certificate content:', cfg.enclavedExpressSSLCert); |
Contributor
There was a problem hiding this comment.
Can we use a better logger then console.log? Is that planned in the future?
Comment on lines
60
to
62
| "engines": { | ||
| "node": ">=14" | ||
| "node": ">=20.18.0" | ||
| } |
Contributor
There was a problem hiding this comment.
Whats the reason for not using 22, or 24?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.