[MBE]: Consolidate unspents for btc by cpatino-intive · Pull Request #43 · BitGo/advanced-wallets

cpatino-intive · 2025-06-25T17:44:37Z

[MBE]: Consolidate unspents for btc
Tasks: WP-4675

mohammadalfaiyazbitgo

some comments to address and please rebase & regenerate the api json.

mohammadalfaiyazbitgo · 2025-06-26T17:15:49Z

src/api/master/routers/masterApiSpec.ts

+
+const ConsolidateUnspentsResponse: HttpResponse = {
+  200: t.any,
+  202: t.any,


where do you return a 202?

mohammadalfaiyazbitgo · 2025-06-26T17:16:04Z

src/api/master/routers/masterApiSpec.ts

+};
+
+const ConsolidateUnspentsResponse: HttpResponse = {
+  200: t.any,


please type this

mohammadalfaiyazbitgo · 2025-06-26T17:17:00Z

src/api/master/routers/masterApiSpec.ts

 };

+export const ConsolidateUnspentsRequest = {
+  pubkey: t.string,


if you have the walletId then you can just retrieve the pub key from the sdk

I've added the pubkey as a param in signing explicilty so they know they need to keep track of the pub. we still verify it against the pubkey on the wallet. can remove this in the future if we want

mohammadalfaiyazbitgo · 2025-06-26T17:17:13Z

src/api/master/routers/masterApiSpec.ts

+  pubkey: t.string,
+  source: t.union([t.literal('user'), t.literal('backup')]),
+  walletPassphrase: t.union([t.undefined, t.string]),
+  xprv: t.union([t.undefined, t.string]),


you don't need this.

@mohammadalfaiyazbitgo mentioned only xprv removed

mohammadalfaiyazbitgo · 2025-06-26T17:18:00Z

src/api/master/handlers/handleConsolidateUnspents.ts

+  const enclavedExpressClient = req.enclavedExpressClient;
+  const reqId = new RequestTracer();
+  const bitgo = req.bitgo;
+  const baseCoin = bitgo.coin((req as any).params.coin);


use req.decoded it will be already typed.

mohammadalfaiyazbitgo · 2025-06-26T17:18:10Z

src/api/master/handlers/handleConsolidateUnspents.ts

+  const params = (req as any).decoded;
+  const walletId = (req as any).params.walletId;


you don't need to cast to any

mohammadalfaiyazbitgo · 2025-06-26T17:19:08Z

src/api/master/handlers/handleConsolidateUnspents.ts

+
+  try {
+    // Create custom signing function that delegates to EBE
+    const customSigningFunction = async (signParams: any) => {


does this need to be typed to any

pranavjain97 · 2025-06-26T19:45:47Z

src/api/master/routers/masterApiSpec.ts

 };

+export const ConsolidateUnspentsRequest = {
+  pubkey: t.string,


I've added the pubkey as a param in signing explicilty so they know they need to keep track of the pub. we still verify it against the pubkey on the wallet. can remove this in the future if we want

pranavjain97 · 2025-06-26T19:46:36Z

src/api/master/routers/masterApiSpec.ts

+export const ConsolidateUnspentsRequest = {
+  pubkey: t.string,
+  source: t.union([t.literal('user'), t.literal('backup')]),
+  walletPassphrase: t.union([t.undefined, t.string]),


remove this please, we're not using wallet passhphrases with onprem

The base branch was changed.

feat(mbp): swagger update

cpatino-intive requested review from mohammadalfaiyazbitgo and pranavjain97 June 25, 2025 18:49

mohammadalfaiyazbitgo requested changes Jun 26, 2025

View reviewed changes

cpatino-intive force-pushed the WP-5142/consolidateunspents branch 2 times, most recently from a1a1bfc to 39e807a Compare June 26, 2025 18:29

cpatino-intive requested a review from mohammadalfaiyazbitgo June 26, 2025 18:33

pranavjain97 reviewed Jun 26, 2025

View reviewed changes

cpatino-intive force-pushed the WP-5142/consolidateunspents branch from 1fb05c1 to 2f9826f Compare June 27, 2025 16:39

cpatino-intive requested a review from pranavjain97 June 27, 2025 16:42

pranavjain97 previously approved these changes Jun 27, 2025

View reviewed changes

cpatino-intive force-pushed the WP-5142/consolidateunspents branch from 6b184dd to a910f96 Compare June 30, 2025 16:07

cpatino-intive dismissed pranavjain97’s stale review via 620f4d6 July 1, 2025 02:03

cpatino-intive force-pushed the WP-5142/consolidateunspents branch from a910f96 to 620f4d6 Compare July 1, 2025 02:03

feat(mbe): consolidate unspents

2b79643

cpatino-intive force-pushed the WP-5142/consolidateunspents branch from 620f4d6 to 58ae73d Compare July 3, 2025 18:20

cpatino-intive changed the base branch from master to WP-4793/utxo-accelerate July 3, 2025 18:21

pranavjain97 previously approved these changes Jul 4, 2025

View reviewed changes

Base automatically changed from WP-4793/utxo-accelerate to master July 7, 2025 11:30

feat(mbe): update api spec

52e6a5a

feat(mbp): swagger update

cpatino-intive force-pushed the WP-5142/consolidateunspents branch from 1715fbb to 52e6a5a Compare July 7, 2025 15:14

feat(mbe): fix import

f6205c2

pranavjain97 approved these changes Jul 7, 2025

View reviewed changes

cpatino-intive requested review from mohammadalfaiyazbitgo and removed request for mohammadalfaiyazbitgo July 7, 2025 18:56

mohammadalfaiyazbitgo approved these changes Jul 7, 2025

View reviewed changes

mohammadalfaiyazbitgo merged commit 47cef83 into master Jul 7, 2025
3 checks passed

mohammadalfaiyazbitgo deleted the WP-5142/consolidateunspents branch July 7, 2025 19:19

		const params = (req as any).decoded;
		const walletId = (req as any).params.walletId;

Conversation

cpatino-intive commented Jun 25, 2025

Uh oh!

mohammadalfaiyazbitgo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants