chore(advanced-wallets): rename enclave to secure express#77
Closed
pranavjain97 wants to merge 3 commits intomasterfrom
Closed
chore(advanced-wallets): rename enclave to secure express#77pranavjain97 wants to merge 3 commits intomasterfrom
pranavjain97 wants to merge 3 commits intomasterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR performs a comprehensive renaming from "enclaved" to "secured express" terminology throughout the codebase. The purpose is to align naming with the actual functionality of the secure key management service. The changes maintain all existing functionality while updating terminology to better reflect the service's role as a secured express server for sensitive operations.
Key Changes:
- Renamed "enclave" terminology to "secured express" across all files and configurations
- Updated configuration variables from
ENCLAVED_EXPRESS_*toSECURED_EXPRESS_* - Modified API endpoints and client names to use "secured" terminology
- Updated documentation and error messages to reflect new naming
Reviewed Changes
Copilot reviewed 72 out of 75 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/types/request.ts | Updated interface to use SecuredExpressClient instead of EnclavedExpressClient |
| src/shared/types/index.ts | Renamed AppMode.ENCLAVED to SECURED and EnclavedConfig to SecuredExpressConfig |
| src/shared/responseHandler.ts | Updated error handling to use securedError instead of EnclavedError |
| src/shared/appUtils.ts | Renamed validation functions and error messages to use secured terminology |
| src/securedExpressApp.ts | Core application file renamed with updated function signatures and logging |
| src/securedBitgoExpress/routers/*.ts | Updated router configurations and API specifications |
| src/routes/*.ts | Updated route setup files with new naming |
| src/kms/kmsClient.ts | Updated client configuration to use SecuredExpressConfig |
| src/initConfig.ts | Comprehensive config updates with new environment variable names |
| src/errors.ts | Renamed EnclavedError to securedError |
| src/api/secured/* | All secured API handlers updated with new type imports |
| src/api/master/routers/securedExpressHealth.ts | Updated health check endpoints from enclavedExpress to securedExpress |
| src/api/master/clients/securedExpressClient.ts | Renamed client class and updated all references |
| src/tests/* | Updated all test files to use new naming and configurations |
| package.json | Updated package name and binary name |
| README.md | Comprehensive documentation updates with new terminology |
| Dockerfile | Updated CMD to use new binary name |
src/shared/appUtils.ts
Outdated
| if (!config.enclavedExpressUrl) { | ||
| throw new Error('ENCLAVED_EXPRESS_URL is required for Master Express mode'); | ||
| if (!config.securedExpressUrl) { | ||
| throw new Error('secured_EXPRESS_URL is required for Master Express mode'); |
There was a problem hiding this comment.
The error message uses 'secured_EXPRESS_URL' with an underscore, but should be 'SECURED_EXPRESS_URL' to match the actual environment variable name format used elsewhere.
Suggested change
| throw new Error('secured_EXPRESS_URL is required for Master Express mode'); | |
| throw new Error('SECURED_EXPRESS_URL is required for Master Express mode'); |
src/shared/appUtils.ts
Outdated
| if (!config.enclavedExpressCert) { | ||
| throw new Error('ENCLAVED_EXPRESS_CERT is required for Master Express mode'); | ||
| if (!config.securedExpressCert) { | ||
| throw new Error('secured_EXPRESS_CERT is required for Master Express mode'); |
There was a problem hiding this comment.
The error message uses 'secured_EXPRESS_CERT' with an underscore, but should be 'SECURED_EXPRESS_CERT' to match the actual environment variable name format used elsewhere.
Suggested change
| throw new Error('secured_EXPRESS_CERT is required for Master Express mode'); | |
| throw new Error('SECURED_EXPRESS_CERT is required for Master Express mode'); |
pranavjain97
force-pushed
the
WP-5298-rename-enclave-to-secure
branch
4 times, most recently
from
789698b to
a0694ca
Compare
mohammadalfaiyazbitgo
requested changes
Jul 21, 2025
Contributor
mohammadalfaiyazbitgo
left a comment
mohammadalfaiyazbitgo
left a comment
There was a problem hiding this comment.
please use the breaking change commit message https://www.conventionalcommits.org/en/v1.0.0/
pranavjain97
force-pushed
the
WP-5298-rename-enclave-to-secure
branch
7 times, most recently
from
8e47335 to
6b4a1b4
Compare
pranavjain97
force-pushed
the
WP-5298-rename-enclave-to-secure
branch
from
6b4a1b4 to
277d8d9
Compare
auto-merge was automatically disabled
July 22, 2025 19:12
Pull request was converted to draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: WP-5298