fix: fix component change detection in endpoints with multiple methods #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shenbenson
force-pushed
the
DX-998-fix-component-change-detection
branch
from
45c3108 to
eda2c8f
Compare
Updates the data structure to store paths affected by component changes. Now each path/method combo tracks its own list of component changes.
shenbenson
force-pushed
the
DX-998-fix-component-change-detection
branch
from
eda2c8f to
c3e83ed
Compare
ericcrosson-bitgo
approved these changes
Feb 4, 2025
Contributor
ericcrosson-bitgo
left a comment
ericcrosson-bitgo
left a comment
There was a problem hiding this comment.
Nice improvement!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After:
This ensures it correctly tracks the components changed in each method of a path