refactor: modify deploy script #156
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venkateshv1266
force-pushed
the
COIN-718-Make-modifications-in-deployment-script-to-accept-the-forwarder-version-param-dynamically-in-eth-multisig-v4-repo
branch
from
9e8521b to
7b478fe
Compare
venkateshv1266
force-pushed
the
COIN-718-Make-modifications-in-deployment-script-to-accept-the-forwarder-version-param-dynamically-in-eth-multisig-v4-repo
branch
from
7b478fe to
fd64a3f
Compare
venkateshv1266
force-pushed
the
COIN-718-Make-modifications-in-deployment-script-to-accept-the-forwarder-version-param-dynamically-in-eth-multisig-v4-repo
branch
from
fd64a3f to
e39959a
Compare
| v4Test: PRIVATE_KEY_FOR_V4_CONTRACT_DEPLOYMENT ?? '', | ||
| v2Prod: MAINNET_PRIVATE_KEY_FOR_CONTRACT_DEPLOYMENT ?? '', | ||
| v2Test: TESTNET_PRIVATE_KEY_FOR_CONTRACT_DEPLOYMENT ?? '', | ||
| v1ProdTestWallet: PRIVATE_KEY_FOR_V1_WALLET_CONTRACT_DEPLOYMENT ?? '', |
Contributor
There was a problem hiding this comment.
Suggested change
| v1ProdTestWallet: PRIVATE_KEY_FOR_V1_WALLET_CONTRACT_DEPLOYMENT ?? '', | |
| v1ProdTestWallet: PRIVATE_KEY_FOR_V4_CONTRACT_DEPLOYMENT_BACKUP ?? '', |
Contributor
Author
There was a problem hiding this comment.
Do we use same private key for wallet and forwarder deployment in v1?
Because I have added something like this...
v1ProdTestWallet: PRIVATE_KEY_FOR_V1_WALLET_CONTRACT_DEPLOYMENT ?? '',
v1ProdTestForwarder: PRIVATE_KEY_FOR_V4_CONTRACT_DEPLOYMENT_BACKUP ?? ''
e39959a to
b8c2168
Compare
venkateshv1266
force-pushed
the
COIN-718-Make-modifications-in-deployment-script-to-accept-the-forwarder-version-param-dynamically-in-eth-multisig-v4-repo
branch
from
b8c2168 to
2a41b69
Compare
venkateshv1266
force-pushed
the
COIN-718-Make-modifications-in-deployment-script-to-accept-the-forwarder-version-param-dynamically-in-eth-multisig-v4-repo
branch
from
2a41b69 to
158a7d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.