fix(wrw): refactor unsigned sweep flow to change exposed fields depending on isTSS #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simhonc
force-pushed
the
WP-3032-refactor-unsigned-sweep-tss-flow
branch
from
aaed7c2 to
d93aed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira: https://bitgoinc.atlassian.net/browse/WP-3032
Prerequisite PR: BitGo/BitGoJS#5103. This needs to be merged in, released, and the SDK needs to be bumped in WRW for this PR to be valid.
This PR refactors the unsigned sweep flow to ask for the user key and backup key if the user selects that the flow is not for a TSS wallet, and ask for only the bitgo key (commonkeychain) if the user selects TSS. To facilitate this, it also moves the checkbox for "Is TSS recovery" to the top of the form.
Screen Recording:
Screen.Recording.2024-11-07.at.10.36.13.AM.mov