-
Notifications
You must be signed in to change notification settings - Fork 46
feat: add coin metadata for multiple EVM coins #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
mullapudipruthvik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there not tests to verify this ?
if not add a recording to validate your changes
prithvishet2503
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add the ApiKeyProvider, minGasLimit , defaultGasLimit ,defaultGasLimitNum and the currency icons
Currency icons are already present in master. |
OttoAllmendinger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automatic comment to flush this PR from my review queue. 🚽🚽🚽
Please re-request another review from the respective team(s) when you are ready for reviews.
|
0xc6889c138e0e3fca860d95c5fac1d0c9fd6b328baa396002476d1e47ff6ed23a pls add the url link to verify |










































Ticket: WIN-7642
Test withdrawal Transaction hash:
0xc6889c138e0e3fca860d95c5fac1d0c9fd6b328baa396002476d1e47ff6ed23a
0x188d77fd58c54912c3d8a3a1903c81d8309b2be2ad28634adaadbff2529c76cd
0xb4c9d6e250e75b171e1e8c57be156595c52d3318269e8cec9af229cae7ae41b2
0x611a2e8aeb392b5cce12d079371c49026de44e6e1aebef1d003d8d711f40dd8e
0x16c7ce7484b042a5500d967cbe80ebed9e52a67cf49541a34d152cf335498b6f