feat: add OP_DROP fixture without enabling support #54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the master branch, we DO want to have the OP_DROP test case, but unlike the beta branch, we make skip the test and make sure descriptor parsing fails with an unknown wrapper error. This reduces the distance between `beta` and `master` branches: less merge conflicts and easier to merge back and forth. Issue: BTC-1829
saravanan7mani
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add test fixture for OP_DROP opcode while keeping it disabled. Descriptor
parsing will fail with "unknown wrapper" error. Reduces code divergence
between beta and master branches for easier merging.
Ticket: BTC-1829