feat: add PSBT private key signing and test utils #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite descriptor template strings as AST nodes for better reliability. Replace string templates with explicit AST node construction. Issue: BTC-1845
Files renamed to better indicate their purpose for fixed script compatibility. Issue: BTC-1845
Adds utils to create and test PSBTs from descriptors with mock inputs and outputs. Issue: BTC-1845
Implement PSBT signing with raw private keys alongside xprv-based signing. Add tests to verify both signing methods. Issue: BTC-1845
OttoAllmendinger
force-pushed
the
BTC-1845.add-p2tr
branch
from
7b106d5 to
57ea243
Compare
lcovar
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add PSBT signing with raw private key buffers alongside xprv-based signing.
Introduce descriptor-based PSBT test utilities with mock inputs/outputs.
Convert descriptor templates to AST format for improved reliability.
Issue: BTC-1845