Use authorized wildcat admin endpoints #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is 📢 Thoughts on this report? Let us know! |
mtbitcr
requested review from
cryptosalomao
and removed request for
codingpeanut157
zupzup
approved these changes
May 20, 2025
mtbitcr
approved these changes
May 20, 2025
src/pages/quotes/QuotePage.tsx
Outdated
| } | ||
|
|
||
| const onActivateKeyset = () => { | ||
| toast.loading("Activating keyset…", { id: `quote-${value.id}-activate-keyset` }) |
There was a problem hiding this comment.
This one could go inside the onMutate callback of activateKeysetMutation mutation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
Changes
Demo environment, please see .env.development
The login for the demo user from wildcat at the time of writing (1b3b3e64af1f48a138ed80e3beb69e2564cc3521) is democat:bitcredit
This update was tested locally without running it in a docker container, pointing toward the keycloak auth endpoint and bff-dashboard-service endpoint from wildcat.
Out of scope
Currently the client and endpoints are generated using open api json. The wildcat admin endpoints are aggregated from multiple services each using their own specification.
Since only a few endpoints are practically used, there is a (re)consideration whether the proceed with OpenAPI generated code.
TODO
✅ Checklist
Please ensure the following tasks are completed before requesting a review:
npm run lintor the equivalent linting command.Screenshots