-
Notifications
You must be signed in to change notification settings - Fork 1
Update first release deployment configs #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||
Dockerfile
Outdated
| ARG VITE_MODE | ||
|
|
||
| FROM node:22.11.0-slim@sha256:f035ba7ffee18f67200e2eb8018e0f13c954ec16338f264940f701997e3c12da AS builder | ||
| FROM node:24.2.0-slim AS builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Pin Docker image digest
| FROM node:24.2.0-slim AS builder | |
| FROM node:24.2.0-slim@sha256:[specific-sha256-hash] AS builder |
cleot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, lgtm!
For our current deployment we don't need docker but good for testing and development. And it will be very useful for kubernetes deployment later on.
Deploying wildcat-dashboard with
|
| Latest commit: |
d00f797
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://163bd5c5.wildcat-dashboard.pages.dev |
| Branch Preview URL: | https://stefan-initial-release2.wildcat-dashboard.pages.dev |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Basic configuration changes for the first stable release 0.1.0
Fixes docker deployment
Afterward a version tag can be created
@cleot Are there any changes required for the current deployment configuration ?