-
Notifications
You must be signed in to change notification settings - Fork 1
feat(ci): implement deployment workflow for tagged versions #60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements a deployment workflow that automatically deploys to a preview environment on tag pushes and enables manual production deployments through workflow_dispatch. Key changes include:
- Automatic Preview Deploys on tag pushes.
- Manual Production Deploys for multiple environments using workflow_dispatch.
- Tag validation to prevent accidental deployments from branches.
Comments suppressed due to low confidence (2)
.github/workflows/deploy-wildcat-docker.yml:62
- Ensure that 'github.ref_type' is reliably available in workflow_dispatch events. If this property is not consistently provided in manual dispatch contexts, consider revising the tag validation logic to verify that deployments are only triggered from tags.
if [[ "${{ github.ref_type }}" != 'tag' ]]; then
.github/workflows/deploy-wildcat-docker.yml:103
- Verify that the production branch is correctly configured. If your repository uses 'main' instead of 'master', update the command accordingly.
command: pages deploy dist --project-name=${{ matrix.project_name }} --branch=master
| - name: Deploy ${{ matrix.environment }} to Cloudflare Pages (PREVIEW) | ||
| id: deploy_preview | ||
| if: github.event_name == 'push' | ||
| uses: cloudflare/wrangler-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step: deploy_preview
| - name: Deploy ${{ matrix.environment }} to Cloudflare Pages (PRODUCTION) | ||
| id: deploy_production | ||
| if: github.event_name == 'workflow_dispatch' | ||
| uses: cloudflare/wrangler-action@v3 |
Check warning
Code scanning / CodeQL
Unpinned tag for a non-immutable Action in workflow Medium
Uses Step: deploy_production
PR Code Suggestions ✨Explore these optional code suggestions:
|
||||||||||||
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
User description
PR Type
Enhancement
Description
• Add GitHub Actions workflow for tagged version deployments
• Support automatic preview deploys on tag push
• Enable manual production deploys via workflow dispatch
• Configure multi-environment matrix for wildcat-docker projects
Changes walkthrough 📝
deploy-wildcat-docker.yml
New deployment workflow for tagged releases.github/workflows/deploy-wildcat-docker.yml
• Creates new GitHub Actions workflow for Cloudflare Pages deployment
• Implements automatic preview deployment on version tag push
• Adds
manual production deployment with environment selection
• Configures
matrix strategy for wildcat-docker and wildcat-dev-docker environments