-
Notifications
You must be signed in to change notification settings - Fork 1
Display Node ID #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Node ID #69
Conversation
PR Reviewer Guide πHere are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the static placeholder in HomePage with a real identityDetail query and adds structured UI cards to display identity information.
- Integrate
identityDetailAPI call viauseSuspenseQuery(with infinite cache settings). - Render separate cards for Information (name, email, DOB), Keys (node ID, Bitcoin key, Nostr key), and Address.
- Remove commented-out placeholders and adjust imports.
Comments suppressed due to low confidence (1)
src/pages/home/HomePage.tsx:15
- Add unit tests for
PageBodycovering cases like no data (renders 'No identity found') and each optional field (email, date_of_birth, postal_address) to ensure correct rendering.
function PageBody() {
PR Code Suggestions β¨Explore these optional code suggestions:
|
|||||||||
Deploying wildcat-dashboard with Β
|
| Latest commit: |
40b462d
|
| Status: | Β β Β Deploy successful! |
| Preview URL: | https://4260d316.wildcat-dashboard.pages.dev |
| Branch Preview URL: | https://stefan-nodeid.wildcat-dashboard.pages.dev |
Codecov ReportAttention: Patch coverage is
π’ Thoughts on this report? Let us know! |
zupzup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM π
π Description
Display Ebill identity data
(Requires Wildcat to expose identity endpoint, latest dev version)
Screenshot
β Checklist
Please ensure the following tasks are completed before requesting a review:
npm run lintor the equivalent linting command.