Skip to content

Display Node ID #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 3, 2025
Merged

Display Node ID #69

merged 7 commits into from
Jul 3, 2025

Conversation

stefanbitcr
Copy link
Contributor

@stefanbitcr stefanbitcr commented Jul 2, 2025 •
edited
Loading

📝 Description

Display Ebill identity data

(Requires Wildcat to expose identity endpoint, latest dev version)

Screenshot

image

✅ Checklist

Please ensure the following tasks are completed before requesting a review:

  • My code adheres to the style guidelines of this project.
  • I have run npm run lint or the equivalent linting command.
  • I have added or updated tests (if applicable).
  • My changes have been tested thoroughly in different browsers/resolutions (if applicable).
  • I have updated the documentation (if applicable).
  • I have checked that there are no console errors or warnings.
  • I have verified that the application builds without errors.
  • I have tested responsiveness for mobile and desktop views (if applicable).

@stefanbitcr stefanbitcr self-assigned this Jul 2, 2025
@stefanbitcr stefanbitcr added the enhancement New feature or request label Jul 2, 2025
@qodo-merge-pro Qodo Merge Pro
Copy link

qodo-merge-pro bot commented Jul 2, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Error Handling

The component lacks proper error handling for the API call. If the identityDetail API fails, the user will see an unhelpful error state. Consider adding error boundaries or try-catch blocks with user-friendly error messages.

 
const { data } = useSuspenseQuery({
  queryKey: ["identity-detail"],
  queryFn: async () => {
    const response = await identityDetail()
    return response.data
  },
  staleTime: Infinity,
  gcTime: Infinity,
})
Data Validation

The postal_address object is accessed without null checking its properties. While the parent object is checked for null, individual properties like address, city, zip, and country could potentially be undefined, leading to runtime errors.

 
<div className="font-medium">{data.postal_address.address}</div>
<div className="text-muted-foreground">
  {data.postal_address.city}
  {data.postal_address.zip && `, ${data.postal_address.zip}`}
</div>
<div className="text-muted-foreground">{data.postal_address.country}</div>

Copilot
Copilot AI reviewed Jul 2, 2025
View reviewed changes
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR replaces the static placeholder in HomePage with a real identityDetail query and adds structured UI cards to display identity information.

  • Integrate identityDetail API call via useSuspenseQuery (with infinite cache settings).
  • Render separate cards for Information (name, email, DOB), Keys (node ID, Bitcoin key, Nostr key), and Address.
  • Remove commented-out placeholders and adjust imports.
Comments suppressed due to low confidence (1)

src/pages/home/HomePage.tsx:15

  • Add unit tests for PageBody covering cases like no data (renders 'No identity found') and each optional field (email, date_of_birth, postal_address) to ensure correct rendering.
function PageBody() {

@qodo-merge-pro Qodo Merge Pro
Copy link

qodo-merge-pro bot commented Jul 2, 2025 •
edited
Loading

PR Code Suggestions ✨

Explore these optional code suggestions:

CategorySuggestion                                                                                                                                    Impact
General
Use consistent client fallback pattern

Use the options.client fallback pattern like other functions in this file. This
ensures consistency and allows client override when needed.

src/generated/client/sdk.gen.ts [161-170]

 export const identityDetail = <ThrowOnError extends boolean = false>(options?: Options<IdentityDetailData, ThrowOnError>) => {
-    return (_heyApiClient).get<IdentityDetailInfo, unknown, ThrowOnError>({
+    return (options?.client ?? _heyApiClient).get<IdentityDetailInfo, unknown, ThrowOnError>({
         url: '/v1/admin/identity/detail',
         ...options,
         headers: {
             'Content-Type': 'application/json',
             ...options?.headers
         }
     });
 };

[To ensure code accuracy, apply this suggestion manually]

Suggestion importance[1-10]: 6

__

Why: This is a good suggestion that improves consistency with other functions in the file, like requestToMint, by allowing the API client to be overridden.

Low
  • Update

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Jul 2, 2025 •
edited
Loading

Deploying wildcat-dashboard with  Cloudflare Pages  Cloudflare Pages

Latest commit: 40b462d
Status: ✅  Deploy successful!
Preview URL: https://4260d316.wildcat-dashboard.pages.dev
Branch Preview URL: https://stefan-nodeid.wildcat-dashboard.pages.dev

View logs

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 82 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/pages/home/HomePage.tsx 0.00% 72 Missing ⚠️
src/generated/client/sdk.gen.ts 0.00% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

zupzup
zupzup approved these changes Jul 2, 2025
View reviewed changes
Copy link

@zupzup zupzup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@stefanbitcr stefanbitcr merged commit 06e2639 into master Jul 3, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@zupzup zupzup zupzup approved these changes

@mtbitcr mtbitcr mtbitcr approved these changes

@cryptosalomao cryptosalomao Awaiting requested review from cryptosalomao

Assignees

@stefanbitcr stefanbitcr

Labels
enhancement New feature or request Review effort 3/5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@stefanbitcr @zupzup @mtbitcr