-
Notifications
You must be signed in to change notification settings - Fork 1
Display network and version #71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds a new section to display mint information fetched from the /v1/info
endpoint and renames the existing info card to “Identity.”
- Imported the
mintInfo
SDK method. - Added a
useSuspenseQuery
call to fetch mint info with infinite caching. - Rendered a “Mint Information” card and updated the old “Information” header to “Identity.”
Comments suppressed due to low confidence (1)
src/pages/home/HomePage.tsx:46
- The newly added Mint Information UI isn't covered by existing tests. Consider adding unit or integration tests to verify the fetch logic and rendering of each field.
{mintData && (
src/pages/home/HomePage.tsx
Outdated
{mintData.contact.map((contact, index) => ( | ||
<span key={index} className="text-sm bg-muted px-2 py-1 rounded"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Using the array index as a React key can lead to rendering issues if the list changes. Use a unique identifier like the contact value instead (e.g., key={contact}
).
{mintData.contact.map((contact, index) => ( | |
<span key={index} className="text-sm bg-muted px-2 py-1 rounded"> | |
{mintData.contact.map((contact) => ( | |
<span key={contact} className="text-sm bg-muted px-2 py-1 rounded"> |
Copilot uses AI. Check for mistakes.
PR Code Suggestions ✨No code suggestions found for the PR. |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
Deploying wildcat-dashboard with
|
Latest commit: |
fd31bc1
|
Status: | ✅ Deploy successful! |
Preview URL: | https://d856afbf.wildcat-dashboard.pages.dev |
Branch Preview URL: | https://stefan-version.wildcat-dashboard.pages.dev |
User description
📝 Description
Displays information from the /v1/info endpoint on the home page, which includes versions of the backend software as well as the Bitcoin network type. The version is contained in the long description fetched from the Wildcat mint.
Requires exposure of v1/info on the admin proxy to be merged
📸 Screenshots/Screen record
✅ Checklist
Please ensure the following tasks are completed before requesting a review:
npm run lint
or the equivalent linting command.PR Type
Enhancement
Description
Add mint information display on home page
Integrate
/v1/admin/info
endpoint for version dataGenerate new API client types and methods
Create responsive grid layout for mint details
Changes diagram
Changes walkthrough 📝
sdk.gen.ts
Add mint info API client method
src/generated/client/sdk.gen.ts
MintInfo
andMintInfoData
type importsmintInfo
function for/v1/admin/info
endpointtypes.gen.ts
Define mint information TypeScript types
src/generated/client/types.gen.ts
MintInfo
type with name, version, description fieldsMintInfoData
type for API request structureHomePage.tsx
Display mint information on home page
src/pages/home/HomePage.tsx
mintInfo
API function