added more voices to the web app#32
Closed
andrepadez wants to merge 7 commits intoBlaizzy:mainfrom
andrepadez:main
Closed
added more voices to the web app#32andrepadez wants to merge 7 commits intoBlaizzy:mainfrom andrepadez:main
andrepadez wants to merge 7 commits intoBlaizzy:mainfrom
andrepadez:main
Conversation
Blaizzy
reviewed
Mar 15, 2025
Owner
There was a problem hiding this comment.
Please revert this change,
PR #35 implements this at the model class level.
Owner
|
This is good addition, thanks @andrepadez! Could you just resolve the conflict and then we merge |
Blaizzy
reviewed
Mar 15, 2025
Comment on lines
+77
to
+80
| mx.eval(result.audio) | ||
|
|
||
| mx.eval(result.audio) | ||
|
|
Owner
There was a problem hiding this comment.
Suggested change
| mx.eval(result.audio) | |
| mx.eval(result.audio) |
Contributor
Author
|
I think it's ready to go |
Contributor
Author
|
is this ^^^^my fault? |
Contributor
Author
|
I'm sorry, i think i just realized what the problem is, i'll delete this pull request and create a fresh one in about an hour. my bad |
Contributor
Author
|
Have to start from scratch, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added the full list of voices (that i know of), including male ones and some other female ones.
Fully tested, locally. All of them work