fix(lid): align ECAPA inference with SpeechBrain#551
Merged
lucasnewman merged 3 commits intoBlaizzy:mainfrom Mar 8, 2026
Merged
fix(lid): align ECAPA inference with SpeechBrain#551lucasnewman merged 3 commits intoBlaizzy:mainfrom
lucasnewman merged 3 commits intoBlaizzy:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Aligns the MLX ECAPA-TDNN LID inference path with SpeechBrain’s behavior to reduce regression risk after introducing the shared ECAPA backbone.
Changes:
- Adds sentence-level mean normalization of mel features before the ECAPA backbone.
- Updates the ECAPA classifier path (LeakyReLU usage and ordering) to match SpeechBrain.
- Adds regression tests covering normalization behavior and classifier operation ordering.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
mlx_audio/lid/models/ecapa_tdnn/ecapa_tdnn.py |
Applies sentence-mean normalization pre-backbone and aligns classifier activation/norm ordering with SpeechBrain. |
mlx_audio/lid/tests/test_lid.py |
Adds targeted regression tests for normalization centering and classifier ordering equivalence. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Now we don't recognize accents the same way as in the original SpeechBrain 😁 |
lucasnewman
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
./.venv/bin/python -m unittest mlx_audio.lid.tests.test_lid.TestEcapaTdnnModel.test_sentence_mean_normalize_centers_each_mel_bin mlx_audio.lid.tests.test_lid.TestEcapaTdnnModel.test_classifier_matches_speechbrain_orderContext
This is the follow-up fix after the shared ECAPA backbone landed in
main. It keeps the MLX LID path aligned with the original SpeechBrain ECAPA inference behavior.