Skip to content

fix(lid): align ECAPA inference with SpeechBrain#551

Merged
lucasnewman merged 3 commits intoBlaizzy:mainfrom
beshkenadze:fix/lid-ecapa-parity-upstream
Mar 8, 2026
Merged

fix(lid): align ECAPA inference with SpeechBrain#551
lucasnewman merged 3 commits intoBlaizzy:mainfrom
beshkenadze:fix/lid-ecapa-parity-upstream

Conversation

@beshkenadze
Copy link
Copy Markdown
Contributor

Summary

  • add sentence-level mean normalization before the ECAPA backbone
  • align the ECAPA classifier path with SpeechBrain
  • add regression coverage for the normalization and classifier ordering

Verification

  • ./.venv/bin/python -m unittest mlx_audio.lid.tests.test_lid.TestEcapaTdnnModel.test_sentence_mean_normalize_centers_each_mel_bin mlx_audio.lid.tests.test_lid.TestEcapaTdnnModel.test_classifier_matches_speechbrain_order

Context

This is the follow-up fix after the shared ECAPA backbone landed in main. It keeps the MLX LID path aligned with the original SpeechBrain ECAPA inference behavior.

Copilot AI review requested due to automatic review settings March 8, 2026 11:11
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Aligns the MLX ECAPA-TDNN LID inference path with SpeechBrain’s behavior to reduce regression risk after introducing the shared ECAPA backbone.

Changes:

  • Adds sentence-level mean normalization of mel features before the ECAPA backbone.
  • Updates the ECAPA classifier path (LeakyReLU usage and ordering) to match SpeechBrain.
  • Adds regression tests covering normalization behavior and classifier operation ordering.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
mlx_audio/lid/models/ecapa_tdnn/ecapa_tdnn.py Applies sentence-mean normalization pre-backbone and aligns classifier activation/norm ordering with SpeechBrain.
mlx_audio/lid/tests/test_lid.py Adds targeted regression tests for normalization centering and classifier ordering equivalence.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@beshkenadze
Copy link
Copy Markdown
Contributor Author

Now we don't recognize accents the same way as in the original SpeechBrain 😁

@lucasnewman lucasnewman merged commit 8aa12ae into Blaizzy:main Mar 8, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants