Conversation
- Add null guards on HttpResponseException.getContent() in catch blocks to prevent NPE from destroying the original PermissionDeniedException (FirewallRule, Instance, GkeCluster, KmsCryptoKey data fetchers) - Add null guards on IAM error details chain (getErrorDetails/getErrorInfo) and extract isServiceDisabled() helper (Policy, Role, ServiceAccount) - Narrow catch(Exception) to catch(IOException) in base fetchers to avoid masking programming errors (Asset, Folder, Organization, Project) - Fix DNS fetcher overbroad 403 catch to check accessNotConfigured reason - Add WARNING logging to all silent continue blocks for API-disabled skips - Move IAM catch blocks inside project loops so one disabled project doesn't skip all remaining projects for that credentials provider - Add pagination to Workspace Directory fetchers (User, Group, Role, RoleAssignment, Member) and Drive fetcher to avoid silent data truncation - Wrap SqlInstanceDataFetcher NetHttpTransport in try-with-resources - Add empty IDs guard in WorkItemDataFetcher - Log DateTimeParseException in WorkItem instead of silently returning null - Add PermissionDeniedException handling to BucketDataFetcher - Fix DriveDataFetcher NPE on getDetails() null chain - Remove commented-out debug code in GCP IAM RoleDataFetcher
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.