feat: add PiKVM module #247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llogen
force-pushed
the
feat/addPiKVModule
branch
2 times, most recently
from
9dbc7d7 to
ad77246
Compare
RiSKeD
reviewed
Dec 8, 2025
llogen
force-pushed
the
feat/addPiKVModule
branch
from
ad77246 to
ae564e7
Compare
Contributor
Author
I think thats a good idea :) |
llogen
force-pushed
the
feat/addPiKVModule
branch
from
ae564e7 to
4e04fe1
Compare
llogen
force-pushed
the
feat/addPiKVModule
branch
4 times, most recently
from
2183a74 to
9454670
Compare
jenstopp
reviewed
Jan 6, 2026
Member
jenstopp
left a comment
jenstopp
left a comment
There was a problem hiding this comment.
Wow, full KVM feature set implemented 🚀 :)
pkg/module/pikvm/pikvm.go
Outdated
Comment on lines
231
to
233
| func (p *PiKVM) doRequest(ctx context.Context, method, urlPath string, body io.Reader, contentType string) (*http.Response, error) { | ||
| return p.doRequestWithOptions(ctx, method, urlPath, body, contentType, requestOptions{}) | ||
| } |
Contributor
Author
There was a problem hiding this comment.
this is for the purpose of not having 3 different methods and combine them within one with the requestOptions input
Comment on lines
301
to
273
| func (p *PiKVM) buildRequestURL(urlPath string) (string, error) { | ||
| targetURL := *p.baseURL | ||
|
|
||
| parsedPath, err := url.Parse(urlPath) | ||
| if err != nil { | ||
| return "", fmt.Errorf("invalid URL path: %v", err) | ||
| } | ||
|
|
||
| targetURL.Path = path.Join(targetURL.Path, parsedPath.Path) | ||
| targetURL.RawQuery = parsedPath.RawQuery | ||
|
|
||
| return targetURL.String(), nil | ||
| } |
RiSKeD
reviewed
Jan 7, 2026
The PiKVM module provides comprehensive control of a DUT via a PiKVM device. It offers power management through ATX control, keyboard input simulation, and virtual media mounting capabilities. Power management commands: on, off, force-off, reset, force-reset, and status. Keyboard control commands: type, key, combo, and paste. Virtual media commands: mount, mount-url, unmount, and media-status. The module connects to a PiKVM device using HTTP/HTTPS with configurable host, user, password, and timeout. It supports both short and long ATX button presses for power and reset control, allows sending keyboard input and key combinations, and enables mounting ISO images from local files or URLs. Signed-off-by: llogen <christoph.lange@blindspot.software>
Signed-off-by: llogen <christoph.lange@blindspot.software>
Add support for streaming file transfers in 1MB chunks to avoid loading large disk images entirely into memory. This fixes OOM issues and connection timeouts when transferring multi-gigabyte files. Changes: - Add FileChunk message to protobuf for streaming file transfers - Implement sendFileInChunks() in client to stream files in 1MB chunks - Implement receiveFileChunk() in client for incoming chunked files - Update agent session to write chunks directly to temp files - Update agent worker to stream files to client in chunks - Remove verbose logging from ChanReader to reduce noise The chunked approach reduces memory usage from ~5GB+ for a 5GB file transfer down to ~1-2MB (only the current chunk in memory). Backward compatible: old File message still supported for small files.
Avoid unnecessary file transfers by calculating SHA256 hash on the client side and checking PiKVM storage before transferring files. Workflow optimization: - Client calculates file hash locally (automated in dutctl) - Agent checks if image already exists on PiKVM by hash - If exists: mount directly without transfer (saves minutes) - If missing: request file from client and upload This significantly improves the user experience when mounting the same disk image multiple times, reducing the operation from ~2-3 minutes (full transfer) to ~2 seconds (hash check only). Example: ./dutctl -s server:1024 device media mount ~/image.img First mount: Calculates hash, transfers 3.5GB, uploads to PiKVM Second mount: Calculates hash, finds on PiKVM, mounts immediately Changes: - Add preprocessArgs() to dutctl for automatic hash calculation - Update PiKVM handleMount() to accept precomputed hash and size - Check PiKVM storage before requesting file from client - Backward compatible: works without hash (calculates server-side)
Signed-off-by: llogen <christoph.lange@blindspot.software>
llogen
force-pushed
the
feat/addPiKVModule
branch
from
ec724a1 to
4be888f
Compare
Member
|
Please put the changes to the file transfer out of this PR (maybe in a separate one). These are serious changes to the core code and need more detailed review and testing. |
Member
@llogen ? I saw the separate PR for the reworked file transfer, but what about getting this parts out of here, so we can get this PR merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PiKVM module provides comprehensive control of a DUT via a PiKVM device. It offers power management through ATX control, keyboard input simulation, and virtual media mounting capabilities.
Power management commands: on, off, force-off, reset, force-reset,
and status. Keyboard control commands: type, key, combo, and paste.
Virtual media commands: mount, mount-url, unmount, and media-status.
The module connects to a PiKVM device using HTTP/HTTPS with configurable host, user, password, and timeout. It supports both short and long ATX button presses for power and reset control, allows sending keyboard input and key combinations, and enables mounting ISO images from local files or URLs.
resolves #246