Open
Conversation
Signed-off-by: daquexian <daquexian566@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a prefetching strategy:
*5+3means the weights of the first 5 layers always remain in GPU memory, and when the i-th layer is executed, the weights of {i+3}-th layer will be prefetched asynchronously into GPU memory (and be dropped once the execution of {i+3}-th layer finishes).Now the old stream strategy like
*5+becomes the abbrev of*5+0The following shows the overlap between the computation cuda stream (blue) and memcpy cuda stream (green):
However, the prefetching feature doesn't necessarily speed up the inference compared to the old stream strategy with the same memory budget (e.g.
*10+10vs*20+0), because memcpy is much slower than computation and cannot be fully overlapped. Here are some benchmarks of 7b world model (bf16, RWKV_JIT_ON=1, RWKV_CUDA_ON=0, A100 80G):7b world model (fp16, RWKV_JIT_ON=1, RWKV_CUDA_ON=1, A100 80G):
BTW, it may be helpful to have a
prepareAPI which prefetches the weights manually to reduce the time offorwardin some scenes.