Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9036c9c73d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| goto :argloop | ||
|
|
||
| :run | ||
| wsl !HERMESC_PATH! !ARGS! |
There was a problem hiding this comment.
The wrapper builds a single ARGS string and executes wsl !HERMESC_PATH! !ARGS! without preserving argument quoting, so any converted path that contains spaces (for example a repo under C:\Users\First Last\...) is split into multiple argv entries before Hermes sees it. In that environment the Hermes compile step receives broken input/output paths and fails the Android build; pass arguments with proper quoting instead of flattening them into an unquoted string.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
It's fine as a temporary windows fix for me
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 344e5d0fe3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {PLATFORM === "ios" && ( | ||
| <InputAccessoryView nativeID={MATH_PAD_NATIVE_ID}> | ||
| <MathPad {...mathPadProps} /> | ||
| </InputAccessoryView> | ||
| <></> | ||
| // <InputAccessoryView nativeID={MATH_PAD_NATIVE_ID}> |
There was a problem hiding this comment.
On iOS this branch now renders only an empty fragment, so the InputAccessoryView/MathPad never mounts even when mathPadProps is provided. That removes the custom math pad from all affected forms and is a user-facing regression in amount-entry flows that depended on this accessory.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Yeah I will follow up this one later. MathPad is disabled for the time being.
1 participant
No description provided.