Add Envelope Class to manage constrained optimization #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
you formatter still doesn't seem to work :) |
Contributor
Author
|
It doesn’t… I also implemented the serialization so I will update the PR |
tomvanmele
approved these changes
Sep 2, 2025
Contributor
tomvanmele
left a comment
tomvanmele
left a comment
There was a problem hiding this comment.
cool, just a few small things
src/compas_tna/envelope/dome.py
Outdated
|
|
||
|
|
||
| def dome_middle(x, y, radius, min_lb, center=(5.0, 5.0)): | ||
| """Update middle of the dome based in the parameters |
Contributor
There was a problem hiding this comment.
... based ON the parameters.
src/compas_tna/envelope/dome.py
Outdated
|
|
||
|
|
||
| def dome_bounds(x, y, thk, min_lb, center=(5.0, 5.0), radius=5.0): | ||
| """Update upper and lower bounds of the dome based in the parameters |
Contributor
There was a problem hiding this comment.
Compute upper and lower bounds ...
|
|
||
|
|
||
| def pavillionvault_middle(x, y, x_span=(0.0, 10.0), y_span=(0.0, 10.0), spr_angle=0.0, tol=1e-6): | ||
| """Update middle of a pavillion vault based in the parameters |
Contributor
There was a problem hiding this comment.
do a find/replace for "based in the parameters" => "based on the parameters"
Contributor
There was a problem hiding this comment.
do a find/replace for """Update => """Compute
Contributor
Author
|
Thanks, updated per review. |
tomvanmele
approved these changes
Sep 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Envelopeclass for masonry structure boundaries with intrados, extrados, and middle meshesEnvelopeclass:from_crossvault()- Creates cross vault envelopes with configurable spans and thicknessfrom_dome()- Creates dome envelopes with configurable radius, center, and oculusfrom_pavillionvault()- Creates pavillion vault envelopes with spring angle supportfrom_pointedvault()- Creates pointed vault envelopes with height control parameterscreate_crossvault_envelope()- Generates cross vault meshes and callablescreate_dome_envelope()- Generates dome meshes with circular topologycreate_pavillionvault_envelope()- Generates pavillion vault meshes with expanded optioncreate_pointedvault_envelope()- Generates pointed vault meshes with height parameterscrossvault_middle_update(),crossvault_ub_lb_update(),crossvault_dub_dlb()dome_middle_update(),dome_ub_lb_update(),dome_dub_dlb()pavillionvault_middle_update(),pavillionvault_ub_lb_update(),pavillionvault_dub_dlb()pointedvault_middle_update(),pointedvault_ub_lb_update(),pointedvault_dub_dlb()