Use zcash_primitives to perform parsing for protocol types.#4
Merged
wolfmcnally merged 7 commits intoBlockchainCommons:masterfrom May 12, 2025
Merged
Conversation
nuttycom
force-pushed
the
primitives_tx_parsing
branch
from
06d1fe1 to
67117c3
Compare
nuttycom
force-pushed
the
primitives_tx_parsing
branch
7 times, most recently
from
e7c76b5 to
c6babb2
Compare
This replaces locally-defined parsing logic with `zcashd`'s parsing code. By using the same versions of `zcash_primitives` and `bridgetree` as `zcashd` uses, we can ensure compatibility and gain access to the protocol data that is needed for type-safe conversion into the `zewif` formats. This also moves the `parser` infrastructure here from the `zewif` crate. The encoding handled by these parsers is `zcashd`-specific, and should not be used by the wider ecosystem.
This also partitions functionality by subprotocol relevance, adding the `transparent`, `sprout`, `sapling`, and `orchard` submodules.
nuttycom
force-pushed
the
primitives_tx_parsing
branch
from
c6babb2 to
01a914e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces locally-defined parsing logic with the same versions of
zcash_primitivesandbridgetreeaszcashduses. By doing so, we can ensure compatibility and gain access to the protocol data that is needed for type-safe conversion into thezewifformats.